Merge pull request #917 from 0xMimir/feat/reduce-logging

Added pre-filter for addresses in kademlia

Author: 0xMimir

core/src/log.rs

@@ -168,7 +168,7 @@ macro_rules! bug_condition {
         .unwrap_or(false) {
             panic!($($arg)*)
         } else {
-            $crate::log::inner::error!($($arg)*)
+            $crate::log::inner::error!("BUG CONDITION: {}", format!($($arg)*))
         }
     }};
 }

p2p/src/network/kad/p2p_network_kad_internals.rs

@@ -566,11 +566,18 @@ impl<const K: usize> P2pNetworkKadBucket<K> {
                 );
             }
 
-            for addr in entry.addrs {
+            let addrs = entry
+                .addrs
+                .into_iter()
+                .filter(|addr| !e.addrs.contains(addr))
+                .collect::<Vec<_>>();
+
+            for addr in addrs {
                 if e.addrs.len() >= P2pNetworkKadEntry::MAX_ADDRS {
                     openmina_core::warn!(
                         openmina_core::log::system_time();
                         kind = "P2pNetworkKadBucket insert",
+                        peer_id = e.peer_id.to_string(),
                         summary = format!("Skipping updates to Kad entry multiaddress list"),
                     );
                     break;