feat(yamux): Reuse the recv buffer

Author: tizoc

p2p/src/network/yamux/p2p_network_yamux_reducer.rs

@@ -47,6 +47,8 @@ impl P2pNetworkYamuxState {
 
         match action {
             P2pNetworkYamuxAction::IncomingData { data, addr } => {
+                // TODO: this may grow over the capacity, if that happens make sure to eventually
+                // truncate it to a reasonable size.
                 yamux_state.buffer.extend_from_slice(&data);
                 let mut offset = 0;
                 loop {
@@ -141,7 +143,9 @@ impl P2pNetworkYamuxState {
                     break;
                 }
 
-                yamux_state.buffer = yamux_state.buffer[offset..].to_vec();
+                let new_len = yamux_state.buffer.len() - offset;
+                yamux_state.buffer.copy_within(offset.., 0);
+                yamux_state.buffer.truncate(new_len);
 
                 let frame_count = yamux_state.incoming.len();
                 let dispatcher = state_context.into_dispatcher();

p2p/src/network/yamux/p2p_network_yamux_state.rs

@@ -4,7 +4,7 @@ use serde::{Deserialize, Serialize};
 
 use super::super::*;
 
-#[derive(Serialize, Deserialize, Debug, Clone, Default)]
+#[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct P2pNetworkYamuxState {
     pub message_size_limit: Limit<usize>,
     pub pending_outgoing_limit: Limit<usize>,
@@ -15,6 +15,20 @@ pub struct P2pNetworkYamuxState {
     pub init: bool,
 }
 
+impl Default for P2pNetworkYamuxState {
+    fn default() -> Self {
+        Self {
+            message_size_limit: Default::default(),
+            pending_outgoing_limit: Default::default(),
+            buffer: Vec::with_capacity(0x40000),   // 256kb
+            incoming: VecDeque::with_capacity(10), // TODO: measure and see what is a good default
+            streams: Default::default(),
+            terminated: Default::default(),
+            init: Default::default(),
+        }
+    }
+}
+
 impl P2pNetworkYamuxState {
     /// Calculates and returns the next available stream ID for outgoing
     /// communication.