Fixed warnings

Author: 0xMimir

Cargo.toml

@@ -51,12 +51,12 @@ mina-p2p-messages = { path = "mina-p2p-messages" }
 poseidon = { path = "poseidon" }
 
 # UNCOMMENTED_IN_CI mina-curves = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina", features = [ "32x9" ] }
-mina-curves = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
-mina-hasher = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
-mina-signer = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 kimchi = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 kimchi-stubs = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
+mina-curves = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
+mina-hasher = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 mina-poseidon = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
+mina-signer = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 o1-utils = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 poly-commitment = { git = "https://github.com/openmina/proof-systems", branch = "rebase-openmina" }
 

core/src/network.rs

@@ -111,7 +111,6 @@ impl NetworkConfig {
 pub mod devnet {
     use super::{CircuitsConfig, NetworkId};
     use crate::constants::{ConstraintConstants, ForkConstants};
-    use mina_curves::pasta::Fp;
 
     pub const NETWORK_ID: NetworkId = NetworkId::TESTNET;
     pub const NAME: &str = "devnet";
@@ -190,7 +189,6 @@ pub mod devnet {
 pub mod mainnet {
     use super::{CircuitsConfig, NetworkId};
     use crate::constants::{ConstraintConstants, ForkConstants};
-    use mina_curves::pasta::Fp;
 
     pub const NETWORK_ID: NetworkId = NetworkId::MAINNET;
     pub const NAME: &str = "mainnet";

ledger/src/proofs/caching.rs

@@ -28,8 +28,6 @@ use poly_commitment::{
 };
 use serde::{Deserialize, Serialize};
 
-use crate::proofs::field::FieldWitness;
-
 use super::VerifierIndex;
 
 fn into<'a, U, T>(slice: &'a [U]) -> Vec<T>

ledger/src/proofs/field.rs

@@ -1,5 +1,5 @@
 use ark_ec::{short_weierstrass::Projective, AffineRepr, CurveGroup};
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, FftField, Field, PrimeField};
+use ark_ff::{BigInteger256, FftField, Field, PrimeField};
 use kimchi::curve::KimchiCurve;
 use mina_curves::pasta::{
     fields::fft::FpParameters as _, Fp, Fq, PallasParameters, ProjectivePallas, ProjectiveVesta,

ledger/src/proofs/public_input/plonk_checks.rs

@@ -495,7 +495,7 @@ mod scalars {
         proof::PointEvaluations,
     };
 
-    use crate::proofs::{field::field::sub, transaction::endos};
+    use crate::proofs::transaction::endos;
 
     use super::*;
 
@@ -754,11 +754,11 @@ mod scalars {
                 let x = sub_eval(x, ctx);
                 field::mul(x, y, ctx.w)
             }
-            Operations::Sub(operations, operations1) => todo!(),
-            Operations::Double(operations) => todo!(),
-            Operations::Square(operations) => todo!(),
-            Operations::Cache(cache_id, operations) => todo!(),
-            Operations::IfFeature(feature_flag, operations, operations1) => todo!(),
+            Operations::Sub(_, _) => todo!(),
+            Operations::Double(_) => todo!(),
+            Operations::Square(_) => todo!(),
+            Operations::Cache(_, _) => todo!(),
+            Operations::IfFeature(_, _, _) => todo!(),
         }
     }
 

ledger/src/proofs/transaction.rs

@@ -8,7 +8,6 @@ use kimchi::{
     groupmap::GroupMap,
     proof::RecursionChallenge,
 };
-use kimchi_stubs::lagrange_basis::WithLagrangeBasis;
 use mina_curves::pasta::{Fp, Fq};
 use mina_p2p_messages::v2::{
     self, ConsensusProofOfStakeDataEpochDataNextValueVersionedValueStableV1,
@@ -25,7 +24,6 @@ use mina_p2p_messages::v2::{
 };
 use mina_poseidon::constants::PlonkSpongeConstantsKimchi;
 use mina_signer::{CompressedPubKey, PubKey};
-use rand::rngs::StdRng;
 
 use crate::{
     decompress_pk, gen_keypair,
@@ -1263,13 +1261,9 @@ impl<F: FieldWitness> InnerCurve<F> {
     where
         S: Into<BigInteger256>,
     {
-        use std::ops::Mul;
         let scale: BigInteger256 = scale.into();
-        let scale = scale.0;
-        // Self {
-        // inner: self.inner.mul(scale),
-        // }
-        todo!()
+        let inner = self.inner.mul_bigint(scale);
+        Self { inner }
     }
 
     fn add_fast(&self, other: Self, w: &mut Witness<F>) -> Self {

ledger/src/proofs/urs_utils.rs

@@ -1,6 +1,6 @@
 /// Copy-pasted from https://github.com/MinaProtocol/mina/blob/cf2a732ae39f4e784707e1fc32832da805bb7d09/src/lib/crypto/kimchi_bindings/stubs/src/urs_utils.rs
 use ark_ec::{AffineRepr, CurveGroup, VariableBaseMSM};
-use ark_ff::{batch_inversion, One, PrimeField, UniformRand, Zero};
+use ark_ff::{batch_inversion, One, UniformRand, Zero};
 use poly_commitment::{
     commitment::{b_poly_coefficients, CommitmentCurve},
     ipa::SRS,

ledger/src/proofs/verifiers.rs

@@ -337,7 +337,7 @@ fn make_verifier_index(index: VerifierIndex<Fq>) -> VerifierIndex<Fq> {
 
     // <https://github.com/o1-labs/proof-systems/blob/2702b09063c7a48131173d78b6cf9408674fd67e/kimchi/src/verifier_index.rs#L310-L314>
     let srs = {
-        let mut srs = SRS::create(max_poly_size);
+        let srs = SRS::create(max_poly_size);
         srs.with_lagrange_basis(domain);
         Arc::new(srs)
     };

ledger/src/proofs/wrap.rs

@@ -1,15 +1,12 @@
 use std::{borrow::Cow, ops::Neg, rc::Rc};
 
 use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, One, Zero};
-use ark_poly::{
-    univariate::DensePolynomial, DenseUVPolynomial, EvaluationDomain, Radix2EvaluationDomain,
-};
+use ark_poly::{univariate::DensePolynomial, DenseUVPolynomial, EvaluationDomain};
 use kimchi::{
     circuits::{expr::RowOffset, scalars::RandomOracles, wires::COLUMNS},
     oracles::OraclesResult,
     proof::{PointEvaluations, ProofEvaluations, RecursionChallenge},
 };
-use kimchi_stubs::WithLagrangeBasis;
 use mina_curves::pasta::{Fp, Fq, Pallas, Vesta};
 use mina_p2p_messages::v2::{
     CompositionTypesBranchDataDomainLog2StableV1, CompositionTypesBranchDataStableV1,
@@ -1879,7 +1876,7 @@ pub mod wrap_verifier {
         let actual_shift = { OPS_BITS_PER_CHUNK * chunks_needed(input_length) };
         let pow2pow = |x: InnerCurve<Fq>, n: usize| (0..n).fold(x, |acc, _| acc.clone() + acc);
 
-        let mut base_and_correction = |h: Domain| {
+        let base_and_correction = |h: Domain| {
             let d = 2u64.pow(h.log2_size() as u32);
             match lagrange_commitment::<Fq>(srs, d, i).chunks.as_slice() {
                 &[g] => {

ledger/src/scan_state/currency.rs

@@ -1,6 +1,6 @@
 use std::cmp::Ordering::{Equal, Greater, Less};
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, Field};
+use ark_ff::{BigInteger256, Field};
 use mina_p2p_messages::v2::BlockTimeTimeStableV1;
 use rand::Rng;