test(p2p): doc and ci for in/out connections

Author: akoptelov

.github/workflows/ci.yaml

@@ -67,6 +67,30 @@ jobs:
           name: tests
           path: tests.tar
 
+  p2p-tests:
+    needs: [ build ]
+    runs-on: ubuntu-20.04
+    container:
+      image: minaprotocol/mina-daemon:2.0.0rampup4-14047c5-focal-berkeley
+    strategy:
+      matrix:
+        test: [p2p_basic_incoming, p2p_basic_outgoing]
+      fail-fast: false
+
+    steps:
+      - name: Download tests
+        uses: actions/download-artifact@v3
+        with:
+          name: tests
+
+      - name: Unpack tests
+        run: |
+          tar xf tests.tar ./${{ matrix.test }}
+
+      - name: Run the test
+        run: |
+          ./${{ matrix.test }} --nocapture --test-threads=1
+
   scenario-tests:
     needs: [ build ]
     runs-on: ubuntu-20.04

node/testing/tests/p2p_basic_incoming.rs

@@ -5,12 +5,12 @@ use openmina_node_testing::scenarios::p2p::basic_incoming_connections::{
 mod common;
 
 scenario_test!(
-    accept_incoming_connection,
+    accept_connection,
     AcceptIncomingConnection,
     AcceptIncomingConnection
 );
 scenario_test!(
-    accept_multiple_incoming_connections,
+    accept_multiple_connections,
     AcceptMultipleIncomingConnections,
     AcceptMultipleIncomingConnections
 );

node/testing/tests/p2p_basic_outgoing.rs

@@ -5,12 +5,12 @@ use openmina_node_testing::scenarios::p2p::basic_outgoing_connections::{
 mod common;
 
 scenario_test!(
-    make_outgoing_connection,
+    make_connection,
     MakeOutgoingConnection,
     MakeOutgoingConnection
 );
 scenario_test!(
-    make_multiple_outgoing_connections,
+    make_multiple_connections,
     MakeMultipleOutgoingConnections,
     MakeMultipleOutgoingConnections
 );

p2p/testing.md

@@ -16,6 +16,8 @@ should be present in the state machine.
 We should accept an incoming connection from an arbitrary node.
 
 **Tests:**
+- [p2p_basic_incoming(accept_connection)](../node/testing/src/scenarios/p2p/basic_incoming_connections.rs#L16)
+- [p2p_basic_incoming(accept_multiple_connections)](../node/testing/src/scenarios/p2p/basic_incoming_connections.rs#L62)
 - [solo_node_accept_incoming](../node/testing/src/scenarios/solo_node/basic_connectivity_accept_incoming.rs)
 - [multi_node_connection_discovery/OCamlToRust](../node/testing/src/scenarios/multi_node/connection_discovery.rs#L127) (should be replaced with one with non-OCaml peer)
 - TODO: fast-running short test
@@ -43,6 +45,11 @@ malicious node that uses the same peer ID.
 
 ## Outgoing connections
 
+### Node should connect to other nodes
+
+- [`p2p_basic_outgoing(make_connection)`](../node/testing/src/scenarios/p2p/basic_outgoing_connections.rs#L19)
+- [`p2p_basic_outgoing(make_multiple_connections)`](../node/testing/src/scenarios/p2p/basic_outgoing_connections.rs#L74)
+
 ### Node should connect to all available initial peers
 
 TODO: what if the number of initial peers exceeds the max number of peers?