fix(yamux): improve error detection

Author: vlad9486

p2p/src/network/scheduler/p2p_network_scheduler_state.rs

@@ -196,8 +196,10 @@ pub enum P2pNetworkConnectionError {
     StreamReset(StreamId),
     #[error("pubsub error: {0}")]
     PubSubError(String),
-    #[error("peer make us keep too much data")]
+    #[error("peer make us keep too much data at stream {0}")]
     YamuxOverflow(StreamId),
+    #[error("peer should not decrease window size at stream {0}")]
+    YamuxBadWindowUpdate(StreamId),
 }
 
 #[derive(Serialize, Deserialize, Debug, Clone)]

p2p/src/network/yamux/p2p_network_yamux_reducer.rs

@@ -344,9 +344,16 @@ impl P2pNetworkYamuxState {
                             });
                         }
                     }
-                    YamuxFrameInner::WindowUpdate { .. } => {
-                        while let Some(frame) = pending_outgoing.pop_front() {
-                            dispatcher.push(P2pNetworkYamuxAction::OutgoingFrame { addr, frame });
+                    YamuxFrameInner::WindowUpdate { difference } => {
+                        if *difference < 0 {
+                            let error =
+                                P2pNetworkConnectionError::YamuxBadWindowUpdate(frame.stream_id);
+                            dispatcher.push(P2pNetworkSchedulerAction::Error { addr, error });
+                        } else {
+                            while let Some(frame) = pending_outgoing.pop_front() {
+                                dispatcher
+                                    .push(P2pNetworkYamuxAction::OutgoingFrame { addr, frame });
+                            }
                         }
                     }
                     _ => {}