-
Notifications
You must be signed in to change notification settings - Fork 40
Closed
Copy link
Labels
Description
For now, we are using a fork, and it is outdated.
https://github.com/openmina/openmina/blob/develop/Cargo.toml#L53-L60
The current version of proof-systems in MinaProtocol/Mina is https://github.com/o1-labs/proof-systems/tree/ff424faac6121ba0cead4adc28ca45c9cdc5ca46.
This is a high priority task as we have to be sure that the cryptography used by the Rust node is the same as the one in the OCaml node. In particular, we must be sure that we constantly use the same version.
This work should be done independently of #1239.
Subtasks
- remove fork openmina/proof-systems (https://github.com/openmina/openmina/blob/develop/Cargo.toml#L53-L60). If any important commit is added in the fork, submit a patch upstream.
- Previous PR opened here from @sebastiencs (sorry for not merging it that time): Upstream openmina changes proof-systems#2750.
- remove fork openmina/algebra (see https://github.com/openmina/openmina/blob/develop/Cargo.toml#L94-L98). This should target the same version as o1-labs/proof-systems. We use now
0.5.0. -
remove fork openmina/num-bigint (https://github.com/openmina/openmina/blob/develop/Cargo.toml#L100). And use the same version as proof-systems. If any important commit is added in the fork, submit a patch upstream. -
remove fork openmina/num-rational (https://github.com/openmina/openmina/blob/develop/Cargo.toml#L101). If any important commit is added in the fork, submit a patch upstream. - ensure that we use the same versions of arkworks package everywhere -> use workspace dependencies for instance.
After that, we can:
- archive openmina/algebra
- archive openmina/num-bigint
- archive openmina/proof-systems
- archive openmina/num-rational
For num-rational and num-bigint, see #1386
Sub-issues
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done