Skip to content

Fix fragile legacy webrtc-multiaddrish parsing code in p2p crate #2074

@richardpringle

Description

@richardpringle

This is... fragile. Think it's worth improving while we're editing this code? These FromStr implementations (at least this and webrtc::SignalingMethod implementations) rely on the leading / instead of using the / as a delimiter and parsing the actual stuff between the /.

Personally, I would be in favour of changing this now so that it doesn't come to bite us at some other point. I realize that would scope creep on this PR though... so, you're call.

Originally posted by @richardpringle in #2052 (comment)

@iostat EDIT: disposition is to remove this parsing with 0.20, along with the Identify fix since that's a "breaking" change to the P2P as well to enable webrtc-relay advertisement.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

In Review

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions