Skip to content

Transaction logic: continue adding docs + tests for invariants #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2025
Merged

Transaction logic: continue adding docs + tests for invariants #1541

merged 5 commits into from
Oct 15, 2025

Conversation

dannywillems
Copy link
Member

In a upcoming patch, we are adding a page on the website describing each type of transactions and methods to operate on the Mina ledger.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 162d5410a894fb9d0da24dd465e63aeba40946bf

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 162d5410a894fb9d0da24dd465e63aeba40946bf)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems moved this to Done in Rust node Oct 14, 2025
@dannywillems dannywillems requested a review from 0xMimir October 14, 2025 15:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems force-pushed the dw/continue-doc-zkapps branch from 50a34e4 to c03ee8f Compare October 14, 2025 16:49
@dannywillems dannywillems self-assigned this Oct 14, 2025
@dannywillems dannywillems force-pushed the dw/continue-doc-zkapps branch 2 times, most recently from 73acd10 to c3c2c67 Compare October 14, 2025 17:10
@dannywillems dannywillems force-pushed the dw/continue-doc-zkapps branch from c3c2c67 to f0cf40e Compare October 15, 2025 07:56
@dannywillems dannywillems merged commit 8b34cb8 into develop Oct 15, 2025
94 of 97 checks passed
@dannywillems dannywillems deleted the dw/continue-doc-zkapps branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xMimir 0xMimir 0xMimir approved these changes

Assignees

@dannywillems dannywillems

Labels

None yet

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannywillems @0xMimir