feat(consensus): Implement block pre-validation #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binier
force-pushed
the
fixes/zura
branch
6 times, most recently
from
a7c0acb to
918ed54
Compare
tizoc
force-pushed
the
fixes/zura
branch
3 times, most recently
from
3dffa89 to
2617ea9
Compare
tizoc
force-pushed
the
fixes/zura
branch
4 times, most recently
from
580062e to
77ba83d
Compare
binier
commented
Nov 23, 2024
tizoc
force-pushed
the
fixes/zura
branch
2 times, most recently
from
d82cf3d to
130290b
Compare
Add more checks to prevalidation. Also use error type for validation failure instead of boolean.
… match the first block time This is required so that the block prevalidation logic doesn't reject the block for being outside of the slot time window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tizoc Please review this commit once you have some time: 23e0d35