address Matt's review

Author: Geometer1729

.github/workflows/build-bindings.yml

@@ -32,7 +32,6 @@ jobs:
           cd src/bindings
           git diff --exit-code
       - name: add build to gc-root if on main
-        # enabeling on this branch for 1 commit to test it
         if: github.ref == 'refs/heads/main'
         run: |
           nix build o1js#o1js-bindings --out-link /home/app/actions-runner/nix-cache/main-bindings-gcroot

flake.nix

@@ -104,10 +104,10 @@
                   ''
                   if [ "$1" = run ] && { [ "$2" = nightly-2023-09-01 ] || [ "$2" = 1.72-x86_64-unknowl-linux-gnu ]; }
                   then
-                    echo USING NIX TOOLCHAIN
+                    echo using nix toolchain
                     ${rustup}/bin/rustup run nix "''${@:3}"
                   else
-                    echo escape rustup "$@"
+                    echo using plain rustup "$@"
                     ${rustup}/bin/rustup "$@"
                   fi
                   '';
@@ -184,7 +184,6 @@
           test-vectors = rust-platform.buildRustPackage {
             src = pkgs.lib.sourceByRegex ./src/mina/src
               [
-                "^lib(/crypto(/kimchi_bindings(/stubs(/.*)?)?)?)?$"
                 "^lib(/crypto(/proof-systems(/.*)?)?)?$"
               ];
             sourceRoot = "source/lib/crypto/proof-systems/poseidon/export_test_vectors";

pin.sh

@@ -9,6 +9,6 @@ git submodule sync && git submodule update --init --recursive
 # Add the flake registry entry
 nix registry add o1js "git+file://$ROOT?submodules=1"
 # update mina input to local submodule
-# --override-input seems redundant but fixes a cacheing issue with local paths
+# --override-input seems redundant but fixes a caching issue with local paths
 nix flake update mina --override-input mina 'path:src/mina' --flake '.?submodules=1'
 popd