refactor: validity check as a static method

Author: boray

src/index.ts

@@ -62,7 +62,7 @@ export { state, State, declareState } from './lib/mina/v1/state.js';
 
 export type { JsonProof } from './lib/proof-system/zkprogram.js';
 export { SelfProof, verify, Empty, Undefined, Void } from './lib/proof-system/zkprogram.js';
-export { VerificationKey, checkVkValidity } from './lib/proof-system/verification-key.js';
+export { VerificationKey } from './lib/proof-system/verification-key.js';
 export { type ProofBase, Proof, DynamicProof } from './lib/proof-system/proof.js';
 export { FeatureFlags } from './lib/proof-system/feature-flags.js';
 export { Cache, CacheHeader } from './lib/proof-system/cache.js';

src/lib/mina/v1/transaction-validation.ts

@@ -21,7 +21,7 @@ import { Types, TypesBigint } from '../../../bindings/mina-transaction/v1/types.
 import type { NetworkId } from '../../../mina-signer/src/types.js';
 import type { Account } from './account.js';
 import type { NetworkValue } from './precondition.js';
-import { checkVkValidity } from '../../proof-system/verification-key.js';
+import { VerificationKey } from '../../proof-system/verification-key.js';
 
 export {
   reportGetAccountError,
@@ -247,7 +247,7 @@ async function verifyAccountUpdate(
       assert(verificationKeyRaw !== undefined, 'Account does not have a verification key');
       let verificationKey = verificationKeyRaw.data;
 
-      const isVkValid = await checkVkValidity(verificationKeyRaw);
+      const isVkValid = await VerificationKey.checkValidity(verificationKeyRaw);
       if (!isVkValid)
         throw Error(`The verification key hash is not consistent with the provided data`);
 
@@ -312,7 +312,9 @@ async function verifyAccountUpdate(
   });
 
   if (accountUpdate.update.verificationKey.isSome.toBoolean()) {
-    const isVkValid = await checkVkValidity(accountUpdate.update.verificationKey.value);
+    const isVkValid = await VerificationKey.checkValidity(
+      accountUpdate.update.verificationKey.value
+    );
     if (!isVkValid)
       throw Error(`The verification key hash is not consistent with the provided data`);
   }

src/lib/proof-system/verification-key.ts

@@ -5,7 +5,7 @@ import { Struct } from '../provable/types/struct.js';
 import { Field } from '../provable/wrapped.js';
 import { inCircuitVkHash } from './zkprogram.js';
 
-export { VerificationKey, checkVkValidity };
+export { VerificationKey };
 
 class VerificationKey extends Struct({
   ...provable({ data: String, hash: Field }),
@@ -28,35 +28,25 @@ class VerificationKey extends Struct({
       hash: Field(RAW_VERIFICATION_KEY.hash),
     });
   }
+
+  static async checkValidity(x: VerificationKey): Promise<boolean> {
+    try {
+      let { runAndCheckSync } = await synchronousRunners();
+
+      runAndCheckSync(() => {
+        let vk = Pickles.sideLoaded.vkToCircuit(() => x.data);
+        let inCircuitHash = inCircuitVkHash(vk);
+        inCircuitHash.assertEquals(x.hash);
+      });
+      return true;
+    } catch {
+      return false;
+    }
+  }
 }
 
 const RAW_VERIFICATION_KEY = {
   hash: '3392518251768960475377392625298437850623664973002200885669375116181514017494',
   // oxlint-disable-line
   data: 'AgIBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBsBAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAALsq7cojes8ZcUc9M9RbZY9U7nhj8KnfU3yTEgqjtXQbAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAC7Ku3KI3rPGXFHPTPUW2WPVO54Y/Cp31N8kxIKo7V0GwEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAuyrtyiN6zxlxRz0z1Ftlj1TueGPwqd9TfJMSCqO1dBs=',
 };
-
-/**
- * Validates a VerificationKey by checking its hash against the hash computed from its data in-circuit.
- *
- * Warning: This function is not meant to be used in provable code.
- *
- * @param vk - The verification key to validate
- * @returns Promise<boolean> - true if the verification key is valid, false otherwise
- * @async
- */
-const checkVkValidity = async (vk: VerificationKey): Promise<boolean> => {
-  try {
-    let { runAndCheckSync } = await synchronousRunners();
-    const verificationKey = VerificationKey.fromValue(vk);
-
-    runAndCheckSync(() => {
-      let vk = Pickles.sideLoaded.vkToCircuit(() => verificationKey.data);
-      let inCircuitHash = inCircuitVkHash(vk);
-      inCircuitHash.assertEquals(verificationKey.hash);
-    });
-    return true;
-  } catch {
-    return false;
-  }
-};