address review comments

Author: dkijania

src/mina-signer/tests/mina-signer-test-app/README.md

@@ -1,37 +1,47 @@
 # Test Signer CLI
 
-Command-line helper for drafting, signing, and broadcasting Mina payments via the public GraphQL API. It wraps the `mina-signer` library so you can submit transactions without wiring up a full wallet or SDK.
+Command-line helper for drafting, signing, and broadcasting Mina payments via
+the public GraphQL API. It wraps the `mina-signer` library so you can submit
+transactions without wiring up a full wallet or SDK.
 
 ## Getting Started
+
 - **Prerequisites:** Node.js 18+ (for native `fetch`) and npm.
 - **Install dependencies:** `npm install`
-- **Quick run:** `node mina-test-signer.js <private_key> <recipient_address> [graphql_url] [nonce]`
+- **Quick run:**
+  `node mina-test-signer.js <private_key> <recipient_address> [graphql_url] [nonce]`
 
-The optional `graphql_url` flag lets you override the default target defined in `config.js`.
+The optional `graphql_url` flag lets you override the default target defined in
+`config.js`.
 
 ## Workflow
+
 1. `mina-test-signer.js` parses CLI arguments and wires the supporting services.
-2. `payment-service.js` derives the sender public key, composes a payment payload, and signs it with `mina-signer`.
-3. `graphql-client.js` sends the signed payload to the Mina daemon and can check whether the transaction reached the pool.
-4. `utils.js` provides small helpers for GraphQL string construction and CLI validation.
-5. `config.js` centralises network defaults and usage messaging.
-
-- `mina-test-signer.js` – CLI entry point orchestrating validation, signing, submission, and pool verification.
-- `payment-service.js` – Thin wrapper around `mina-signer` with sensible defaults for MINA amounts and fees.
-- `graphql-client.js` – Minimal fetch-based GraphQL transport for sending payments and querying pooled commands.
-- `utils.js` – GraphQL stringification helpers plus basic CLI argument validation/parsing.
+2. `graphql-client.js` sends the signed payload to the Mina daemon and can check
+   whether the transaction reached the pool.
+3. `utils.js` provides small helpers for GraphQL string construction and CLI
+   validation.
+4. `config.js` centralises network defaults and usage messaging.
+
+- `mina-test-signer.js` – CLI entry point orchestrating validation, signing,
+  submission, and pool verification.
+- `payment-service.js` – Thin wrapper around `mina-signer` with sensible
+  defaults for MINA amounts and fees.
+- `graphql-client.js` – Minimal fetch-based GraphQL transport for sending
+  payments and querying pooled commands.
+- `utils.js` – GraphQL stringification helpers plus basic CLI argument
+  validation/parsing.
 - `config.js` – Configuration constants and usage text surfaced by the CLI.
-- `key/` – Sample key material for experimentation; do not use in production environments.
+- `key/` – Sample key material for experimentation; do not use in production
+  environments.
 
-Check the console output for a transaction id; you can re-run the pool check or the `getPooledUserCommands` helper to confirm inclusion.
-Provide a `nonce` argument when you need to synchronise with on-chain account state manually.
-The CLI prints emoji-enhanced step logs and a summary table so you can spot successes and failures at a glance.
-GraphQL errors (including malformed responses) cause the CLI to exit with a non-zero status so they can be surfaced in scripts and CI.
-
-## Customisation Tips
-- Update `CONFIG.DEFAULT_GRAPHQL_URL` in `config.js` to point at your daemon or a hosted GraphQL endpoint.
-- Tweak `CONFIG.MINA_UNITS.DEFAULT_AMOUNT_MULTIPLIER` and `DEFAULT_FEE_MULTIPLIER` to adjust the default transaction values.
-- Extend `GraphQLClient` with additional queries (e.g. account state, balances) if you need richer diagnostics.
+Check the console output for a transaction id; you can re-run the pool check or
+the `getPooledUserCommands` helper to confirm inclusion. Provide a `nonce`
+argument when you need to synchronise with on-chain account state manually. The
+CLI prints emoji-enhanced step logs and a summary table so you can spot
+successes and failures at a glance. GraphQL errors (including malformed
+responses) cause the CLI to exit with a non-zero status so they can be surfaced
+in scripts and CI.
 
 ## Private key format
 
@@ -42,5 +52,8 @@ For clarity, private key is in output format of:
 ```
 
 ## Safety Notes
-- Treat private keys in plain text with care. Prefer environment variables or a secure secrets manager for real deployments.
-- The example keys under `key/` are for local testing only; they are publicly known and should never hold funds.
+
+- Treat private keys in plain text with care. Prefer environment variables or a
+  secure secrets manager for real deployments.
+- The example keys under `key/` are for local testing only; they are publicly
+  known and should never hold funds.

src/mina-signer/tests/mina-signer-test-app/config.js

@@ -14,11 +14,11 @@ export const CONFIG = {
 };
 
 /**
- * Human-friendly CLI usage text that `test-signer.js` displays when
+ * Human-friendly CLI usage text that `mina-test-signer.js` displays when
  * the caller provides incomplete arguments.
  */
 export const USAGE_INFO = {
-  message: 'Usage: node test-signer.js <private_key> <recipient_address> [graphql_url] [nonce]',
-  example: 'Example: node test-signer.js EKErBK1KznrJJY3raJafSyxSayJ6viejaVrmjzXkSmoxXiJQsesU  B62qp4wcxoJyFFyXZ2RVw8kGPpWn6ncK4RtsTz29jFf6fY2XYN42R1v http://172.17.0.3:3085/graphql 3',
+  message: 'Usage: node mina-test-signer.js <private_key> <recipient_address> [graphql_url] [nonce]',
+  example: 'Example: node mina-test-signer.js EKErBK1KznrJJY3raJafSyxSayJ6viejaVrmjzXkSmoxXiJQsesU  B62qp4wcxoJyFFyXZ2RVw8kGPpWn6ncK4RtsTz29jFf6fY2XYN42R1v http://172.17.0.3:3085/graphql 3',
   defaultUrl: `Default GraphQL URL: ${CONFIG.DEFAULT_GRAPHQL_URL}`
 };

src/mina-signer/tests/mina-signer-test-app/graphql-client.js

@@ -26,7 +26,7 @@ export class GraphQLClient {
       const response = await fetch(this.url, {
         method: 'POST',
         headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ operationName: null, query, variables: {} }),
+        body: JSON.stringify({ query }),
       });
 
       return await this.handleResponse(response);

src/mina-signer/tests/mina-signer-test-app/mina-test-signer.js

@@ -9,7 +9,7 @@
  *  - Submit the signed payload to a Mina daemon and verify it reached the pool
  *
  * Usage:
- *    node test-signer.js --private-key <key> --recipient <address> [--url <graphql_url>] [--nonce <nonce>]
+ *    node mina-test-signer.js --private-key <key> --recipient <address> [--url <graphql_url>] [--nonce <nonce>]
  */
 import { Command } from 'commander';
 import { GraphQLClient } from './graphql-client.js';

src/mina-signer/tests/mina-signer-test-app/package-lock.json

@@ -1,8 +1,8 @@
 {
-  "name": "test-signer",
+  "name": "mina-test-signer",
   "type": "module",
   "version": "1.0.0",
-  "main": "test-signer.js",
+  "main": "mina-test-signer.js",
   "bin": {
     "mina-test-signer": "mina-test-signer.js"
   },
@@ -12,10 +12,10 @@
   },
   "author": "o1-labs",
   "license": "ISC",
-  "description": "test app for mina-test-signer",
+  "description": "test app for mina-signer",
   "dependencies": {
     "commander": "^14.0.2",
     "json-to-graphql-query": "^2.3.0",
-    "mina-signer": "^1.7.0"
+    "mina-signer": "../../../mina-signer"
   }
 }