Merge pull request #1996 from o1-labs/fix/snarky-undefined

Make sure bindings are initialized before accessing snarky

Author: Trivo25

CHANGELOG.md

@@ -25,6 +25,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Sort order for actions now includes the transaction sequence number and the exact account id sequence https://github.com/o1-labs/o1js/pull/1917
 - Updated typedoc version for generating docs https://github.com/o1-labs/o1js/pull/1973
 
+### Fixed
+
+- Fix behavior of `initializeBindings()` when called concurrently, to improve error messages in common failure scenarios https://github.com/o1-labs/o1js/pull/1996
+
 ## [2.2.0](https://github.com/o1-labs/o1js/compare/e1bac02...b857516) - 2024-12-10
 
 ### Added

src/snarky.js

@@ -3,11 +3,17 @@ import { wasm, withThreadPool } from './bindings/js/node/node-backend.js';
 
 let Snarky, Ledger, Pickles, Test_;
 let isInitialized = false;
+let initializingPromise;
 
 async function initializeBindings() {
   if (isInitialized) return;
-  isInitialized = true;
+  if (initializingPromise) {
+    await initializingPromise;
+    return;
+  }
   let snarky;
+  let resolve;
+  initializingPromise = new Promise((r) => (resolve = r));
 
   // this dynamic import makes jest respect the import order
   // otherwise the cjs file gets imported before its implicit esm dependencies and fails
@@ -18,6 +24,9 @@ async function initializeBindings() {
     await import('./bindings/compiled/_node_bindings/o1js_node.bc.cjs')
   ).default;
   ({ Snarky, Ledger, Pickles, Test: Test_ } = snarky);
+  resolve();
+  initializingPromise = undefined;
+  isInitialized = true;
 }
 
 async function Test() {