Merge pull request #3414 from o1-labs/dw/no-std

feat: add no-std feature to mina-hasher, mina-poseidon, and mina-signer

Author: dannywillems

.github/workflows/ci-lint.yml

@@ -63,30 +63,5 @@ jobs:
         run: |
           # Load OCaml environment
           eval $(opam env)
-
-          # List of crates to exclude (not yet fixed for this Rust version)
-          # Remove crates from this list as they are fixed.
-          # See https://github.com/o1-labs/mina-rust/issues/1926 for tracking.
-          EXCLUDED_CRATES=(
-          )
-
-          # Count workspace members
-          WORKSPACE_MEMBERS=$(cargo metadata --no-deps --format-version 1 | jq '.packages | length')
-          EXCLUDED_COUNT=${#EXCLUDED_CRATES[@]}
-
           echo "Rust toolchain: ${{ matrix.rust_toolchain }}"
-          echo "Workspace has $WORKSPACE_MEMBERS crates, excluding $EXCLUDED_COUNT"
-
-          if [ "$WORKSPACE_MEMBERS" -eq "$EXCLUDED_COUNT" ]; then
-            echo "All crates are excluded, nothing to lint."
-            exit 0
-          fi
-
-          # Build the exclude arguments
-          EXCLUDE_ARGS=""
-          for crate in "${EXCLUDED_CRATES[@]}"; do
-            EXCLUDE_ARGS="$EXCLUDE_ARGS --exclude $crate"
-          done
-
-          # Run clippy with exclusions
-          cargo clippy --workspace $EXCLUDE_ARGS --all-features --all-targets -- -W clippy::all -D warnings
+          make lint

.github/workflows/ci.yml

@@ -168,7 +168,8 @@ jobs:
         run: |
           eval $(opam env)
           make test-doc
-      - name: generate docs
+
+      - name: Generate docs
         run: |
           eval $(opam env)
           make generate-doc
@@ -209,8 +210,35 @@ jobs:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: ./book/book/html
 
+  # Tracking issue: https://github.com/o1-labs/mina-rust/issues/1984
+  no-std-check:
+    name: "no_std: ${{ matrix.crate.name }}"
+    needs: ['refresh-cache']
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        crate:
+          # Crates with no-std feature
+          - { name: "mina-hasher", path: "hasher" } # https://github.com/o1-labs/mina-rust/issues/1994
+          - { name: "mina-poseidon", path: "poseidon" } # https://github.com/o1-labs/mina-rust/issues/1996
+          - { name: "mina-signer", path: "signer" } # https://github.com/o1-labs/mina-rust/issues/1995
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Use shared Rust toolchain setting up steps
+        uses: ./.github/actions/toolchain-shared
+        with:
+          rust_toolchain_version: stable
+
+      - name: Check ${{ matrix.crate.name }} (no_std)
+        run: |
+          cd ${{ matrix.crate.path }}
+          cargo check --no-default-features
+
   build:
-    needs: ['define-matrix', 'refresh-cache']
+    needs: ['define-matrix', 'refresh-cache', 'no-std-check']
     strategy:
       matrix:
         rust_and_os: ${{ fromJSON(needs.define-matrix.outputs.matrix).include }}

.github/workflows/test-export-vectors.yml

@@ -39,7 +39,7 @@ jobs:
       - name: Build export_test_vectors binary
         run: |
           eval $(opam env)
-          cargo build --bin export_test_vectors --all-features
+          cargo build --bin export_test_vectors
 
       - name: Test export_test_vectors commands
         run: |
@@ -55,16 +55,21 @@ jobs:
               for output_format in $OUTPUT_FORMATS; do
                 echo "Testing $format $mode --format $output_format..."
                 if [ "$output_format" = "json" ]; then
-                  cargo run --bin export_test_vectors --all-features -- $format $mode /tmp/test_${format}_${mode}.json --format $output_format
+                  cargo run --bin export_test_vectors -- \
+                    $format $mode /tmp/test_${format}_${mode}.json \
+                    --format $output_format
                 else
-                  cargo run --bin export_test_vectors --all-features -- $format $mode /tmp/test_${format}_${mode}.js --format $output_format
+                  cargo run --bin export_test_vectors -- \
+                    $format $mode /tmp/test_${format}_${mode}.js \
+                    --format $output_format
                 fi
               done
             done
           done
 
           echo "Testing stdout output..."
-          cargo run --bin export_test_vectors --all-features -- b10 legacy - > /tmp/test_stdout.json
+          cargo run --bin export_test_vectors -- b10 legacy - \
+            > /tmp/test_stdout.json
 
       - name: Verify output files
         run: |

CHANGELOG.md

@@ -14,7 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Skip macOS tests and docs jobs on PRs to improve CI velocity; macOS runs on master only
   ([#3429](https://github.com/o1-labs/proof-systems/pull/3429),
   [o1-labs/mina-rust#2024](https://github.com/o1-labs/mina-rust/issues/2024))
-- Flag `test_lazy_mode_benchmark` as a heavy test to skip on regular CI runs ([#3430](https://github.com/o1-labs/proof-systems/pull/3430))
+- Flag `test_lazy_mode_benchmark` as a heavy test to skip on regular CI runs
+  ([#3430](https://github.com/o1-labs/proof-systems/pull/3430))
+- Add no-std compatibility check workflow that verifies crates compile with `--no-default-features`
+  ([#3414](https://github.com/o1-labs/proof-systems/pull/3414))
 
 ### [arrabbiata](./arrabbiata)