Skip to content

Commit c44771a

Browse files
authored
Merge pull request #3543 from o1-labs/mesa/fully-remove-cairo
Fully remove Cairo gates
2 parents e713722 + 6834f0a commit c44771a

File tree

4 files changed

+5
-16
lines changed

4 files changed

+5
-16
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ and this project adheres to
2020
- Fix lookup selector polynomials to work correctly when chunking is in place
2121
([#3541](https://github.com/o1-labs/proof-systems/pull/3541))
2222

23+
### Removed
24+
25+
- Fully remove Cairo gate variants in `GateType`
26+
([#3543](https://github.com/o1-labs/proof-systems/pull/3543))
27+
2328
## 0.5.0
2429

2530
### [kimchi](./kimchi)

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ The project is organized in the following way:
7070
- [poseidon/](poseidon/). Implementation of the poseidon hash function.
7171
- [signer/](signer/). Interfaces for mina signature schemes.
7272
- [tools/](tools/). Various tooling to help us work on kimchi.
73-
- [turshi/](turshi/). A Cairo runner written in rust.
7473
- [utils/](utils/). Collection of useful functions and traits.
7574

7675
## Contributing

kimchi/src/circuits/gate.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,6 @@ pub enum GateType {
8282
EndoMulScalar,
8383
// Lookup
8484
Lookup,
85-
// TODO: remove Cairo gate types
86-
/// Cairo
87-
CairoClaim,
88-
CairoInstruction,
89-
CairoFlags,
90-
CairoTransition,
9185
/// Range check
9286
RangeCheck0,
9387
RangeCheck1,
@@ -183,7 +177,6 @@ impl<F: PrimeField> CircuitGate<F> {
183177
// TODO: implement the verification for the lookup gate
184178
// See https://github.com/MinaProtocol/mina/issues/14011
185179
Lookup => Ok(()),
186-
CairoClaim | CairoInstruction | CairoFlags | CairoTransition => Ok(()),
187180
RangeCheck0 | RangeCheck1 => self
188181
.verify_witness::<FULL_ROUNDS, G>(row, witness, &index.cs, public)
189182
.map_err(|e| e.to_string()),
@@ -282,13 +275,6 @@ impl<F: PrimeField> CircuitGate<F> {
282275
// See https://github.com/MinaProtocol/mina/issues/14011
283276
vec![]
284277
}
285-
// TODO: remove Cairo gate types
286-
GateType::CairoClaim
287-
| GateType::CairoInstruction
288-
| GateType::CairoFlags
289-
| GateType::CairoTransition => {
290-
vec![]
291-
}
292278
GateType::RangeCheck0 => {
293279
range_check::circuitgates::RangeCheck0::constraint_checks(&env, &mut cache)
294280
}

kimchi/src/verifier.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ impl<
9595
EndoMul => Some(&self.verifier_index.emul_comm),
9696
EndoMulScalar => Some(&self.verifier_index.endomul_scalar_comm),
9797
Poseidon => Some(&self.verifier_index.psm_comm),
98-
CairoClaim | CairoInstruction | CairoFlags | CairoTransition => None,
9998
RangeCheck0 => Some(self.verifier_index.range_check0_comm.as_ref()?),
10099
RangeCheck1 => Some(self.verifier_index.range_check1_comm.as_ref()?),
101100
ForeignFieldAdd => Some(self.verifier_index.foreign_field_add_comm.as_ref()?),

0 commit comments

Comments
 (0)