fix(curves): allow asm cfg from ark-ff derive macros #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/fix-curves-clippy-191
branch
from
6dc9abf to
e657010
Compare
iostat
reviewed
Dec 2, 2025
| edition = "2021" | ||
| license = "Apache-2.0" | ||
|
|
||
| [lints.rust] |
There was a problem hiding this comment.
Just curious on the motivation for adding this as a lint exemption as opposed to explicitly listing the features in the crate manifest. My understanding is that derive macros are producing these feature-gates which aren't explicitly listed and the linter isn't pleased with that. But from a tooling perspective, the lint is absolutely correct in that code is being produced which may never be enabled because the corresponding features aren't defined.
I believe the following would be the idiomatic way to resolve the warning which preserves the lint's intent.
[features]
asm = []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.