Skip to content

Commit 7fdb9c9

Browse files
authored
feat: added delete user with id method in users module (#161)
1 parent 0d0d9f1 commit 7fdb9c9

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

.changeset/brown-sloths-stick.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@o2s/framework': patch
3+
'@o2s/integrations.mocked': patch
4+
---
5+
6+
added delete user with id method in users module

packages/framework/src/modules/users/users.controller.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,13 @@ export class UserController {
5353

5454
@Delete('/me')
5555
@Auth.Roles({ roles: [Auth.Constants.Roles.USER, Auth.Constants.Roles.ADMIN] })
56-
deleteUser(@Headers() headers: AppHeaders) {
57-
return this.userService.deleteUser(headers.authorization);
56+
deleteCurrentUser(@Headers() headers: AppHeaders) {
57+
return this.userService.deleteCurrentUser(headers.authorization);
58+
}
59+
60+
@Delete(':id')
61+
@Auth.Roles({ roles: [Auth.Constants.Roles.USER, Auth.Constants.Roles.ADMIN] })
62+
deleteUser(@Param() params: Request.GetUserParams, @Headers() headers: AppHeaders) {
63+
return this.userService.deleteUser(params, headers.authorization);
5864
}
5965
}

packages/framework/src/modules/users/users.service.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,6 @@ export abstract class UserService {
2727
options: Users.Request.GetCustomerParams,
2828
authorization?: string,
2929
): Observable<Customer | undefined>;
30-
abstract deleteUser(authorization?: string): Observable<void>;
30+
abstract deleteCurrentUser(authorization?: string): Observable<void>;
31+
abstract deleteUser(options: Users.Request.GetUserParams, authorization?: string): Observable<void>;
3132
}

packages/integrations/mocked/src/modules/users/users.service.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@ export class UserService implements Users.Service {
3535
return of(mapCustomer(options.id)).pipe(responseDelay());
3636
}
3737

38-
deleteUser(): Observable<void> {
38+
deleteCurrentUser(): Observable<void> {
39+
throw new NotImplementedException('Delete current user method not implemented');
40+
}
41+
42+
deleteUser(_options: Users.Request.GetUserParams): Observable<void> {
3943
throw new NotImplementedException('Delete user method not implemented');
4044
}
4145
}

0 commit comments

Comments
 (0)