Skip to content

Commit 9b6926c

Browse files
committed
feat: added user id in delete method params
1 parent fb98e38 commit 9b6926c

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

.changeset/brown-sloths-stick.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@o2s/framework': patch
3+
'@o2s/integrations.mocked': patch
4+
---
5+
6+
modified delete user method params in users module to contain id of user

packages/framework/src/modules/users/users.controller.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ export class UserController {
5151
return this.userService.getCurrentUserCustomer(params, headers.authorization);
5252
}
5353

54-
@Delete('/me')
54+
@Delete(':id')
5555
@Auth.Roles({ roles: [Auth.Constants.Roles.USER, Auth.Constants.Roles.ADMIN] })
56-
deleteUser(@Headers() headers: AppHeaders) {
57-
return this.userService.deleteUser(headers.authorization);
56+
deleteUser(@Param() params: Request.GetUserParams, @Headers() headers: AppHeaders) {
57+
return this.userService.deleteUser(params, headers.authorization);
5858
}
5959
}

packages/framework/src/modules/users/users.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ export abstract class UserService {
2727
options: Users.Request.GetCustomerParams,
2828
authorization?: string,
2929
): Observable<Customer | undefined>;
30-
abstract deleteUser(authorization?: string): Observable<void>;
30+
abstract deleteUser(options: Users.Request.GetUserParams, authorization?: string): Observable<void>;
3131
}

packages/integrations/mocked/src/modules/users/users.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class UserService implements Users.Service {
3535
return of(mapCustomer(options.id)).pipe(responseDelay());
3636
}
3737

38-
deleteUser(): Observable<void> {
38+
deleteUser(options: Users.Request.GetUserParams): Observable<void> {
3939
throw new NotImplementedException('Delete user method not implemented');
4040
}
4141
}

0 commit comments

Comments
 (0)