for review

Author: Sk7Str1p3

src/cli.rs

@@ -37,6 +37,8 @@ pub struct CliOptions {
     #[command(flatten)]
     pub visuals: VisualsCliOptions,
     #[command(flatten)]
+    pub config: ConfigCliOptions,
+    #[command(flatten)]
     pub developer: DeveloperCliOptions,
     #[command(flatten)]
     pub other: OtherCliOptions,
@@ -213,6 +215,18 @@ pub struct VisualsCliOptions {
     pub nerd_fonts: bool,
 }
 
+#[derive(Clone, Debug, Args, PartialEq, Eq)]
+#[command(next_help_heading = "CONFIG")]
+pub struct ConfigCliOptions {
+    /// Path to the config file
+    #[arg(long, value_hint = ValueHint::FilePath)]
+    pub config_path: PathBuf,
+    /// Creates a default config file
+    /// Writes to $XDG_CONFIG_HOME/onefetch/config.toml but can be overridden with --config-path
+    #[arg(long)]
+    pub generate_config: bool,
+}
+
 #[derive(Clone, Debug, Args, PartialEq, Eq, Default)]
 #[command(next_help_heading = "DEVELOPER")]
 pub struct DeveloperCliOptions {
@@ -244,6 +258,7 @@ impl Default for CliOptions {
             visuals: VisualsCliOptions::default(),
             ascii: AsciiCliOptions::default(),
             image: ImageCliOptions::default(),
+            config: ConfigCliOptions::default(),
             developer: DeveloperCliOptions::default(),
             other: OtherCliOptions::default(),
         }
@@ -302,6 +317,16 @@ impl Default for ImageCliOptions {
     }
 }
 
+impl Default for ConfigCliOptions {
+    fn default() -> Self {
+        ConfigCliOptions {
+            // Not sure about unwrap
+            config_path: dirs::config_dir().unwrap().join("onefetch/config.toml"),
+            generate_config: false,
+        }
+    }
+}
+
 pub fn print_supported_languages() -> Result<()> {
     for l in Language::iter() {
         println!("{l}");

src/config.rs

@@ -0,0 +1,58 @@
+use anyhow::Result;
+use serde::{Deserialize, Serialize};
+use std::{fs, path::Path};
+
+use crate::info::utils::info_field::InfoType;
+
+#[derive(Serialize, Deserialize)]
+pub struct ConfigOptions {
+    #[serde(default)]
+    pub disabled_fields: Vec<InfoType>,
+}
+
+impl Default for ConfigOptions {
+    fn default() -> Self {
+        Self {
+            disabled_fields: vec![],
+        }
+    }
+}
+
+impl ConfigOptions {
+    pub fn read<P>(path: P) -> Self
+    // Is it even should panic?
+    where
+        P: AsRef<Path>,
+    {
+        let contents = fs::read_to_string(path);
+        match contents {
+            Err(_) => Self::default(),
+            Ok(contents) => {
+                // I wish to print exact error here, like syntax errors
+                toml::from_str(&contents).unwrap()
+            }
+        }
+    }
+
+    pub fn write_default<P>(path: P) -> Result<()>
+    // I believe user would like to generate config with CLI flags
+    // I mean to write disabled_fields with --disabled-fields flag
+    where
+        // Nah this feels really bad but rust-analyser told me to add ' + std::fmt::Display'
+        P: AsRef<Path> + std::fmt::Display,
+    {
+        // I dont think this can panic so i simply unwrapped it
+        let defaults = toml::to_string(&Self::default()).unwrap();
+        match fs::create_dir_all(&path) {
+            Ok(_) => match fs::write(&path, &defaults) {
+                Ok(_) => println!("Default config file created at: {path}"),
+                Err(e) => eprintln!("Failed to write default config file: {}", e),
+            },
+            Err(e) => {
+                eprintln!("Failed to create config directory {path}: {e}");
+            }
+        }
+        // Im not sure it should return simple Ok(())?
+        Ok(())
+    }
+}

src/info/mod.rs

@@ -22,6 +22,7 @@ use self::url::UrlInfo;
 use self::utils::info_field::{InfoField, InfoType};
 use self::version::VersionInfo;
 use crate::cli::{is_truecolor_terminal, CliOptions, NumberSeparator, When};
+use crate::config::ConfigOptions;
 use crate::ui::get_ascii_colors;
 use crate::ui::text_colors::TextColors;
 use anyhow::{Context, Result};
@@ -109,7 +110,7 @@ impl std::fmt::Display for Info {
     }
 }
 
-pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
+pub fn build_info(cli_options: &CliOptions, config_options: &ConfigOptions) -> Result<Info> {
     let mut repo = gix::ThreadSafeRepository::discover_opts(
         &cli_options.input,
         gix::discover::upwards::Options {
@@ -178,7 +179,7 @@ pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
     let globs_to_exclude = &cli_options.info.exclude;
     let show_email = cli_options.info.email;
 
-    Ok(InfoBuilder::new(cli_options)
+    Ok(InfoBuilder::new(cli_options, config_options)
         .title(&repo, no_bold, &text_colors)
         .project(&repo, &repo_url, manifest.as_ref(), number_separator)?
         .description(manifest.as_ref())
@@ -217,10 +218,12 @@ pub fn build_info(cli_options: &CliOptions) -> Result<Info> {
 }
 
 impl InfoBuilder {
-    fn new(cli_options: &CliOptions) -> Self {
+    fn new(cli_options: &CliOptions, config_options: &ConfigOptions) -> Self {
         Self {
             title: None,
             info_fields: Vec::new(),
+            // I have totally NO idea how to properly override values
+            // if cli_options.info.disabled_fields is NOT type of Option<T>
             disabled_fields: cli_options.info.disabled_fields.clone(),
             no_title: cli_options.info.no_title,
         }

src/info/utils/info_field.rs

@@ -1,5 +1,6 @@
 use crate::{info::utils::get_style, ui::text_colors::TextColors};
 use owo_colors::OwoColorize;
+use serde::{Deserialize, Serialize};
 use std::fmt;
 
 #[typetag::serialize]
@@ -55,7 +56,7 @@ pub trait InfoField {
     }
 }
 
-#[derive(Clone, clap::ValueEnum, Debug, Eq, PartialEq)]
+#[derive(Clone, clap::ValueEnum, Debug, Eq, PartialEq, Serialize, Deserialize)]
 pub enum InfoType {
     Project,
     Description,

src/lib.rs

@@ -2,3 +2,4 @@
 pub mod cli;
 pub mod info;
 pub mod ui;
+pub mod config;

src/main.rs

@@ -4,6 +4,7 @@ use anyhow::Result;
 use clap::{CommandFactory, Parser};
 use human_panic::setup_panic;
 use onefetch::cli::{self, CliOptions};
+use onefetch::config::ConfigOptions;
 use onefetch::info::build_info;
 use onefetch::ui::printer::Printer;
 use std::io;
@@ -30,7 +31,15 @@ fn main() -> Result<()> {
         return Ok(());
     }
 
-    let info = build_info(&cli_options)?;
+    if cli_options.config.generate_config {
+        // @spenserblack fixme pls
+        // it complans if i add .display(), and complains if i remove .display()
+        return ConfigOptions::write_default(cli_options.config.config_path.display());
+    }
+
+    let config_options = ConfigOptions::read(&cli_options.config.config_path);
+
+    let info = build_info(&cli_options, &config_options)?;
 
     let mut printer = Printer::new(io::BufWriter::new(io::stdout()), info, cli_options)?;