Skip to content

Commit f85cbdc

Browse files
committed
small updates to issue triage guide
Signed-off-by: Tom Hulton-Harrop <[email protected]>
1 parent 7113353 commit f85cbdc

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

rfcs/Issue_Triage_Guide.md

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,35 @@ While the [common issue triage guide for O3DE](https://github.com/o3de/community
66

77
This guide covers how to triage GitHub issues for SIG-Simulation. Maintainers are encouraged to use and update this guide to ensure all contributors to SIG-Simulation understands how issues are handled and accepted by the SIG.
88

9-
## Issue Triaging
9+
## Issue Triaging
1010

1111
Triaging is the process used to handle intake of issues into the SIG-Simulation backlog. The process aims to ensure issues are both relevant to SIG-Simulation and contain sufficient information so that the community can take action.
1212

1313
Process aims to ensure that:
14+
1415
* Issues are appropriate for SIG-Simulation. Confirms that issues are actual issues, rather than requests for help or issues for another SIG.
1516
* Issues have clear information to enable SIG-Simulation to address the problem or request.
16-
* Issues are regularly maintained and updated until they are resolved.
17+
* Issues are regularly maintained and updated until they are resolved.
1718
* Issue load is balanced across SIG maintainers when action is required.
1819
* All the SIG-Simulation community can participate.
1920

20-
# Process
21+
## Process
2122

2223
SIG-Simulation triages issues once a week on [Thursday](https://lists.o3de.org/g/o3de-calendar/calendar). Anyone is welcome to attend. Triage will be led by SIG chair, co-chair or maintainer (referred to below as *Triage Leader*)
2324

2425
## Triage Leader Guide
2526

2627
1. Join the SIG-Simulation discord voice channel
27-
2. Announce yourself as the Triage Leader and wait a few minutes for others to join the call.
28-
3. Use the *Individual Issue Triage* guide below to process all new issues for SIG:
29-
1. Review any open issues with [needs-sig](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-sig) that may be for SIG Simulation
30-
1. Remove `needs-sig` and add `sig/simulation`. These items will now show up when reviewing issues below.
31-
2. Process the main repository issues
28+
1. Announce yourself as the *Triage Leader* and wait a few minutes for others to join the call.
29+
1. Use the *Individual Issue Triage* guide below to process all new issues for SIG:
30+
1. Review any open issues with [needs-sig](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-sig) that may be for SIG-Simulation
31+
1. Remove `needs-sig` and add `sig/simulation`. These items will now show up when reviewing issues below.
32+
2. Process the main repository issues. As issues are triaged, please see if they can be categorized and added to the [O3DE Simulation Bugs board](https://github.com/orgs/o3de/projects/26/views/1?groupedBy%5BcolumnId%5D=25435410).
3233
1. [Blocker Issues](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation++label%3Apriority%2Fblocker+sort%3Acreated-asc)
33-
1. [Critical issues](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation++label%3Apriority%2Fcritical+sort%3Acreated-asc)
34-
2. [Major issues](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation++label%3Apriority%2Fmajor+sort%3Acreated-asc)
35-
3. [Other issues sorted by age](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation+sort%3Acreated-asc)
36-
4. Process all the new points in a similar way for:
34+
2. [Critical issues](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation++label%3Apriority%2Fcritical+sort%3Acreated-asc)
35+
3. [Major issues](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation++label%3Apriority%2Fmajor+sort%3Acreated-asc)
36+
4. [Other issues sorted by age](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Aneeds-triage+label%3Asig%2Fsimulation+sort%3Acreated-asc)
37+
3. Process all the new points in a similar way for:
3738
1. [SIG-Simulation Issues](https://github.com/o3de/sig-simulation/issues)
3839
2. [SIG-Simulation PRs](https://github.com/o3de/sig-simulation/pulls)
3940
3. [PhysX Issues](https://github.com/o3de/PhysX/issues)
@@ -45,30 +46,30 @@ If there are questions about what to do with an issue please raise questions wit
4546

4647
### Individual Issue Triage
4748

48-
1. (Recommendation) Announce issue number and title to those in Discord voice channel, so others can follow along.
49-
4. (Main issues only) Ensure issue is for SIG-Simulation.
50-
1. If the issue is not for SIG-Simulation, remove the `sig/simulation` label and comment on the issue as to reason why issue is not for SIG-Simulation.
51-
2. If the correct SIG is known assign issue to that SIG. Otherwise, add the `needs-sig` label so the general O3DE issue triage meeting can find the appropriate owners.
52-
5. Review the issue and any comments to see if it can be accepted by SIG
49+
1. (Recommendation) Announce issue number and title to those in Discord voice channel, so others can follow along.
50+
1. (Main issues only) Ensure issue is for SIG-Simulation.
51+
1. If the issue is not for SIG-Simulation, remove the `sig/simulation` label and comment on the issue as to reason why issue is not for SIG-Simulation.
52+
2. If the correct SIG is known assign issue to that SIG. Otherwise, add the `needs-sig` label so the general O3DE issue triage meeting can find the appropriate owners.
53+
1. Review the issue and any comments to see if it can be accepted by SIG
5354
1. **If issue is a bug**: Check that report has enough information for someone to reproduce or understand the issue?
54-
2. **If issue is a feature request**: Review the technical implications of the request.
55-
1. If it's a large change then the issue should become an RFC or be brought to the SIG-Simulation meeting for discussion.
55+
2. **If issue is a feature request**: Review the technical implications of the request.
56+
1. If it's a large change then the issue should become an RFC or be brought to the SIG-Simulation meeting for discussion.
5657
1. Ask requestor to bring the issue back as an RFC or start a discussion topic.
57-
2. Add the issue to the next SIG-Simulation meeting agenda, if that would be more appropriate.
58-
6. If issue can be **accepted** then:
58+
2. Add the issue to the next SIG-Simulation meeting agenda, if that would be more appropriate.
59+
1. If issue can be **accepted** then:
5960
1. If issue is a bug, add the `kind/bug` label.
60-
2. If issue is for a feature request, add either `kind/feature`, `kind/enhancement`, or `kind/task`. Add the relevant feature labels as appropriate, e.g., `feature/physics` or `feature/animation`.
61-
5. Set a **priority** using a `priority/X` tag for issue based on impact (ask other SIG members on call for guidance). For feature requests, also set an appropriate `feature-need/X` tag.
62-
7. Mark the issue as `triage/accepted`.
63-
8. If the issue **requires more information** or is **rejected**, then:
61+
1. If issue is for a feature request, add either `kind/feature`, `kind/enhancement`, or `kind/task`. Add the relevant feature labels as appropriate, e.g., `feature/physics` or `feature/animation`.
62+
1. Set a **priority** using a `priority/X` tag for issue based on impact (ask other SIG members on call for guidance). For feature requests, also set an appropriate `feature-need/X` tag.
63+
1. Mark the issue as `triage/accepted`.
64+
1. If the issue **requires more information** or is **rejected**, then:
6465
1. Assign a reviewer, if required, to handle follow-up comments, to reproduce the issue or ask for further clarifying information.
65-
4. **If issue is rejected**: Reviewer/triage leader should reject issue and provide reason for rejection.
66+
1. **If issue is rejected**: Reviewer/triage leader should reject issue and provide reason for rejection.
6667
1. Mark the issue as `triage/declined`.
67-
5. **If issue needs more information**: Reviewer/triage leader should add clear comments requesting the additional information.
68+
1. **If issue needs more information**: Reviewer/triage leader should add clear comments requesting the additional information.
6869
1. Mark the issue with `triage/needs-information`. It's recommended that all issues in this state have an assigned reviewer who will track updates until all required information is received. Issue can then be reconsidered for acceptance.
69-
9. If we need feedback on a particular UX workflow, add labels `needs-ux-info` or `needs-ux-action`.
70-
10. Remove the `needs-triage` label from issue.
71-
11. Add comments to issue, when appropriate, to capture issue triage decisions.
70+
1. If we need feedback on a particular UX workflow, add labels `needs-ux-info` or `needs-ux-action`.
71+
1. Remove the `needs-triage` label from issue.
72+
1. Add comments to issue, when appropriate, to capture issue triage decisions.
7273

7374
### Additional Labels to Consider for Contributors
7475

@@ -84,10 +85,10 @@ If time permits (select some of these):
8485
* Review any open [blocker](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fsimulation+label%3Apriority%2Fblocker) and [critical](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fsimulation+label%3Apriority%2Fcritical) issues in the main repository:
8586
* Ensures priority is still valid. Ensures issues are still valid.
8687
* Assign any required commentators or ask for updates.
87-
* Review PRs for the SIG that are more than [30 days old](https://github.com/o3de/o3de/pulls?q=is%3Apr+is%3Aopen+label%3Asig%2Fsimulation+sort%3Acreated-asc) old, ensure PR appears to be active or ask contributor for to update PR or close out.
88-
* Ensures PRs are still active and are not blocked on contributor or maintainer action.
88+
* Review PRs for the SIG that are more than [30 days old](https://github.com/o3de/o3de/pulls?q=is%3Apr+is%3Aopen+label%3Asig%2Fsimulation+sort%3Acreated-asc) old, ensure PR appears to be active or ask contributor for to update PR or close out.
89+
* Ensures PRs are still active and are not blocked on contributor or maintainer action.
8990
* Review issues that are more than [90 days old](https://github.com/o3de/o3de/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fsimulation+sort%3Acreated-asc)
90-
* Ensures issues are still relevant to SIG.
91+
* Ensures issues are still relevant to SIG.
9192

9293
## Issue Workflow
9394

@@ -130,7 +131,6 @@ An issue without `triage/accepted` label is considered abandoned if there has be
130131
4. What can I do if I have a question for SIG-Simulation?
131132
1. The preferred way to raise questions is through the [SIG-Simulation Discord chat channel](https://discord.gg/6nSYcUBaR3) or the [SIG-Simulation discussion panel](https://github.com/o3de/sig-simulation/discussions).
132133

133-
134134
## Acknowledgments
135135

136136
This guide was informed by the [SIG-Network Triage Guide](https://raw.githubusercontent.com/o3de/sig-network/main/TRIAGE_GUIDE.md)

0 commit comments

Comments
 (0)