Improves API integration resilience

oDaviML · oDaviML · commit d4398511d39a · 2026-02-12T15:12:43.000-03:00
Adds exception handling for external API integrations, specifically for the Coordenadas API, to prevent cascading failures.
Includes detailed logging for integration errors, including endpoint, error type, and transaction ID.

Implements retry logic in the scheduler for coordenada fetching and adds timeout configurations to the WebClient to avoid indefinite waiting.
Preserves existing data when API integration fails by preventing the saving of empty coordinate lists.
diff --git a/src/main/java/com/dmware/api_onibusbh/config/WebClientConfig.java b/src/main/java/com/dmware/api_onibusbh/config/WebClientConfig.java
@@ -1,10 +1,18 @@
 package com.dmware.api_onibusbh.config;
 
+import io.netty.channel.ChannelOption;
+import io.netty.handler.timeout.ReadTimeoutHandler;
+import io.netty.handler.timeout.WriteTimeoutHandler;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.http.HttpHeaders;
+import org.springframework.http.client.reactive.ReactorClientHttpConnector;
 import org.springframework.web.reactive.function.client.ExchangeStrategies;
 import org.springframework.web.reactive.function.client.WebClient;
+import reactor.netty.http.client.HttpClient;
+
+import java.time.Duration;
+import java.util.concurrent.TimeUnit;
 
 @Configuration
 public class WebClientConfig {
@@ -16,10 +24,18 @@ public WebClient webClient() {
                 .codecs(codecs -> codecs.defaultCodecs().maxInMemorySize(size))
                 .build();
 
+        HttpClient httpClient = HttpClient.create()
+                .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 10000)
+                .responseTimeout(Duration.ofSeconds(15))
+                .doOnConnected(conn -> conn
+                        .addHandlerLast(new ReadTimeoutHandler(15, TimeUnit.SECONDS))
+                        .addHandlerLast(new WriteTimeoutHandler(10, TimeUnit.SECONDS)));
+
         return WebClient.builder()
                 .defaultHeader(HttpHeaders.USER_AGENT, "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36")
                 .defaultHeader(HttpHeaders.REFERER, "https://dados.pbh.gov.br/")
                 .exchangeStrategies(strategies)
+                .clientConnector(new ReactorClientHttpConnector(httpClient))
                 .build();
     }
 }
diff --git a/src/main/java/com/dmware/api_onibusbh/exceptions/CoordenadasApiIntegrationException.java b/src/main/java/com/dmware/api_onibusbh/exceptions/CoordenadasApiIntegrationException.java
@@ -0,0 +1,26 @@
+package com.dmware.api_onibusbh.exceptions;
+
+public class CoordenadasApiIntegrationException extends RuntimeException {
+    private final String endpoint;
+    private final String errorType;
+
+    public CoordenadasApiIntegrationException(String message, String endpoint, String errorType, Throwable cause) {
+        super(message, cause);
+        this.endpoint = endpoint;
+        this.errorType = errorType;
+    }
+
+    public CoordenadasApiIntegrationException(String endpoint, String errorType, Throwable cause) {
+        super("Falha na integração com API externa de coordenadas");
+        this.endpoint = endpoint;
+        this.errorType = errorType;
+    }
+
+    public String getEndpoint() {
+        return endpoint;
+    }
+
+    public String getErrorType() {
+        return errorType;
+    }
+}
diff --git a/src/main/java/com/dmware/api_onibusbh/infra/CustomExceptionHandler.java b/src/main/java/com/dmware/api_onibusbh/infra/CustomExceptionHandler.java
@@ -17,6 +17,8 @@
 
 import static net.logstash.logback.argument.StructuredArguments.kv;
 
+import com.dmware.api_onibusbh.exceptions.CoordenadasApiIntegrationException;
+
 @ControllerAdvice
 public class CustomExceptionHandler extends ResponseEntityExceptionHandler {
 
@@ -168,4 +170,21 @@ public ResponseEntity<ErrorResponse> rateLimitExceededException(RateLimitExceede
                 .body(new ErrorResponse(java.time.LocalDateTime.now(), ex.getMessage(), HttpStatus.TOO_MANY_REQUESTS));
     }
 
+    @ExceptionHandler(CoordenadasApiIntegrationException.class)
+    public ResponseEntity<ErrorResponse> coordenadasApiIntegrationException(CoordenadasApiIntegrationException ex, HttpServletRequest request) {
+        String clientIp = ClientIpUtils.getClientIp(request);
+        logger.error("Falha na integração com API externa | {} {} | IP: {} | Endpoint: {} | Tipo: {} | Mensagem: {}",
+                request.getMethod(), request.getRequestURI(), clientIp, ex.getEndpoint(), ex.getErrorType(), ex.getMessage(),
+                kv("exception", ex.getClass().getSimpleName()),
+                kv("status", HttpStatus.SERVICE_UNAVAILABLE),
+                kv("endpoint", ex.getEndpoint()),
+                kv("error_type", ex.getErrorType()),
+                kv("detail", ex.getMessage()),
+                kv("path", request.getRequestURI()),
+                kv("method", request.getMethod()),
+                kv("client_ip", clientIp),
+                ex);
+        return ErrorResponse.of("Falha na comunicação com serviço externo. Os dados existentes foram preservados.", HttpStatus.SERVICE_UNAVAILABLE);
+    }
+
 }
diff --git a/src/main/java/com/dmware/api_onibusbh/scheduler/CoordenadasScheduler.java b/src/main/java/com/dmware/api_onibusbh/scheduler/CoordenadasScheduler.java
@@ -1,6 +1,7 @@
 package com.dmware.api_onibusbh.scheduler;
 
 import com.dmware.api_onibusbh.dto.CoordenadaDTO;
+import com.dmware.api_onibusbh.exceptions.CoordenadasApiIntegrationException;
 import com.dmware.api_onibusbh.services.APIService;
 import com.dmware.api_onibusbh.services.OnibusService;
 import org.slf4j.MDC;
@@ -28,16 +29,39 @@ public CoordenadasScheduler(APIService apiService, OnibusService onibusService)
     @Scheduled(fixedDelay = 20, timeUnit = TimeUnit.SECONDS)
     public void fetchCoordenadasOnibus() {
         long startTime = System.currentTimeMillis();
+        String transactionId = UUID.randomUUID().toString();
         try {
-            MDC.put("transaction_id", UUID.randomUUID().toString());
+            MDC.put("transaction_id", transactionId);
             logger.info("Job de Coordenadas iniciado.", kv("job_name", "Coordenadas"), kv("status", "STARTED"));
             List<CoordenadaDTO> coordenadas = apiService.getOnibusCoordenadaBH();
             onibusService.salvaCoordenadas(coordenadas);
             long duration = System.currentTimeMillis() - startTime;
             logger.info("Job de Coordenadas finalizado | Tempo: {}ms", duration,
                 kv("job_name", "Coordenadas"), 
                 kv("status", "FINISHED"), 
-                kv("duration_ms", duration));
+                kv("duration_ms", duration),
+                kv("transaction_id", transactionId));
+        } catch (CoordenadasApiIntegrationException e) {
+            long duration = System.currentTimeMillis() - startTime;
+            logger.error("Falha na integração com API externa. Coordenadas preservadas. Tentando novamente em 20s.",
+                kv("job_name", "Coordenadas"),
+                kv("status", "FAILED"),
+                kv("error_type", "API_INTEGRATION"),
+                kv("endpoint", e.getEndpoint()),
+                kv("error_detail", e.getErrorType()),
+                kv("duration_ms", duration),
+                kv("transaction_id", transactionId),
+                kv("next_retry_seconds", 20));
+        } catch (Exception e) {
+            long duration = System.currentTimeMillis() - startTime;
+            logger.error("Erro inesperado no job de coordenadas. Tentando novamente em 20s.", e,
+                kv("job_name", "Coordenadas"),
+                kv("status", "FAILED"),
+                kv("error_type", "UNEXPECTED"),
+                kv("error_class", e.getClass().getSimpleName()),
+                kv("duration_ms", duration),
+                kv("transaction_id", transactionId),
+                kv("next_retry_seconds", 20));
         } finally {
             MDC.clear();
         }
diff --git a/src/main/java/com/dmware/api_onibusbh/services/APIService.java b/src/main/java/com/dmware/api_onibusbh/services/APIService.java
@@ -3,6 +3,7 @@
 import com.dmware.api_onibusbh.dto.CoordenadaDTO;
 import com.dmware.api_onibusbh.dto.DicionarioDTO;
 import com.dmware.api_onibusbh.dto.LinhaDTO;
+import com.dmware.api_onibusbh.exceptions.CoordenadasApiIntegrationException;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.JsonNode;
@@ -18,6 +19,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import static net.logstash.logback.argument.StructuredArguments.kv;
+
 @Service
 public class APIService {
 
@@ -32,11 +35,16 @@ public APIService(WebClient webClient, ObjectMapper objectMapper) {
     }
 
     public List<DicionarioDTO> getDicionarioAPIBH() {
+        String endpoint = "ckan.pbh.gov.br/dicionario";
         try {
             String json = webClient.get()
                     .uri("https://ckan.pbh.gov.br/api/3/action/datastore_search?resource_id=825337e5-8cd5-43d9-ac52-837d80346721&limit=20")
                     .retrieve()
                     .bodyToMono(String.class)
+                    .onErrorResume(e -> {
+                        logger.error("Erro ao buscar dicionário da API BH", kv("endpoint", endpoint), kv("error", e.getMessage()));
+                        return Mono.error(new CoordenadasApiIntegrationException("Falha ao buscar dicionário", endpoint, e.getClass().getSimpleName(), e));
+                    })
                     .block();
 
             JsonNode rootNode = objectMapper.readTree(json);
@@ -45,17 +53,23 @@ public List<DicionarioDTO> getDicionarioAPIBH() {
             return objectMapper.convertValue(recordsNode, new TypeReference<List<DicionarioDTO>>() {
             });
 
-        } catch (JsonProcessingException | WebClientResponseException e) {
-            throw new RuntimeException(e);
+        } catch (JsonProcessingException e) {
+            logger.error("Erro ao processar JSON do dicionário", kv("endpoint", endpoint), kv("error", e.getMessage()));
+            throw new CoordenadasApiIntegrationException("Erro ao processar resposta do dicionário", endpoint, "JsonProcessingException", e);
         }
     }
 
     public List<LinhaDTO> getLinhasAPIBH() {
+        String endpoint = "ckan.pbh.gov.br/linhas";
         try {
             String json = webClient.get()
                     .uri("https://ckan.pbh.gov.br/api/3/action/datastore_search?resource_id=150bddd0-9a2c-4731-ade9-54aa56717fb6&limit=3000")
                     .retrieve()
                     .bodyToMono(String.class)
+                    .onErrorResume(e -> {
+                        logger.error("Erro ao buscar linhas da API BH", kv("endpoint", endpoint), kv("error", e.getMessage()));
+                        return Mono.error(new CoordenadasApiIntegrationException("Falha ao buscar linhas", endpoint, e.getClass().getSimpleName(), e));
+                    })
                     .block();
 
             JsonNode rootNode = objectMapper.readTree(json);
@@ -64,16 +78,25 @@ public List<LinhaDTO> getLinhasAPIBH() {
             return objectMapper.convertValue(recordsNode, new TypeReference<List<LinhaDTO>>() {
             });
 
-        } catch (JsonProcessingException | WebClientResponseException e) {
-            throw new RuntimeException(e);
+        } catch (JsonProcessingException e) {
+            logger.error("Erro ao processar JSON das linhas", kv("endpoint", endpoint), kv("error", e.getMessage()));
+            throw new CoordenadasApiIntegrationException("Erro ao processar resposta das linhas", endpoint, "JsonProcessingException", e);
         }
     }
 
     public List<CoordenadaDTO> getOnibusCoordenadaBH() {
         List<String> responses = fetchCoordenadasDirectly();
 
         if (responses == null || responses.size() < 2) {
-            throw new IllegalStateException("Não foi possível obter resposta de um ou mais endpoints.");
+            throw new CoordenadasApiIntegrationException("Resposta incompleta das APIs de coordenadas", "temporeal.pbh.gov.br", "IncompleteResponse", null);
+        }
+
+        String jsonD = responses.get(0);
+        String jsonSD = responses.get(1);
+
+        if ("[]".equals(jsonD) && "[]".equals(jsonSD)) {
+            logger.warn("Ambas as APIs de coordenadas retornaram vazio");
+            throw new CoordenadasApiIntegrationException("APIs de coordenadas retornaram dados vazios", "temporeal.pbh.gov.br", "EmptyResponse", null);
         }
 
         return processAndReturnCoordenadas(responses);
@@ -85,17 +108,17 @@ private List<String> fetchCoordenadasDirectly() {
                 .retrieve()
                 .bodyToMono(String.class)
                 .onErrorResume(e -> {
-                    logger.error("Erro ao buscar coordenadas D", e);
-                    return Mono.just("[]");
+                    logger.error("Erro ao buscar coordenadas D", kv("param", "D"), kv("error", e.getMessage()));
+                    return Mono.error(new CoordenadasApiIntegrationException("Falha ao buscar coordenadas D", "temporeal.pbh.gov.br/?param=D", e.getClass().getSimpleName(), e));
                 });
 
         Mono<String> monoParamSD = webClient.get()
                 .uri("https://temporeal.pbh.gov.br/?param=SD")
                 .retrieve()
                 .bodyToMono(String.class)
                 .onErrorResume(e -> {
-                    logger.error("Erro ao buscar coordenadas SD", e);
-                    return Mono.just("[]");
+                    logger.error("Erro ao buscar coordenadas SD", kv("param", "SD"), kv("error", e.getMessage()));
+                    return Mono.error(new CoordenadasApiIntegrationException("Falha ao buscar coordenadas SD", "temporeal.pbh.gov.br/?param=SD", e.getClass().getSimpleName(), e));
                 });
 
         return Flux.mergeSequential(monoParamD, monoParamSD).collectList().block();
@@ -119,7 +142,7 @@ private List<CoordenadaDTO> processAndReturnCoordenadas(List<String> responses)
             return todasCoordenadas;
 
         } catch (JsonProcessingException e) {
-            throw new RuntimeException("Erro ao processar o JSON das coordenadas.", e);
+            throw new CoordenadasApiIntegrationException("Erro ao processar JSON das coordenadas", "temporeal.pbh.gov.br", "JsonProcessingException", e);
         }
     }
-}
+}
diff --git a/src/main/java/com/dmware/api_onibusbh/services/OnibusService.java b/src/main/java/com/dmware/api_onibusbh/services/OnibusService.java
@@ -86,6 +86,12 @@ public List<CoordenadaDTO> listarPorNumeroLinha(Integer numeroLinha, Optional<In
     @CacheEvict(value = {"onibus", "onibusPorLinha"}, allEntries = true)
     public void salvaCoordenadas(List<CoordenadaDTO> todasCoordenadasNovas) {
         logger.info("Iniciando o salvamento das coordenadas...");
+
+        if (todasCoordenadasNovas == null || todasCoordenadasNovas.isEmpty()) {
+            logger.error("Lista de coordenadas está vazia ou nula. Abortando salvamento para preservar dados existentes.");
+            return;
+        }
+
         List<LinhaEntity> linhasExistentes;
         try {
             linhasExistentes = linhasRepository.findAll();
