Skip to content

Commit 6eea9c9

Browse files
committed
Fix release workflow secret usage in if conditions
1 parent 2493541 commit 6eea9c9

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

.github/workflows/release.yml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ permissions:
1212
jobs:
1313
build-android:
1414
runs-on: ubuntu-latest
15+
env:
16+
ANDROID_KEYSTORE_BASE64: ${{ secrets.ANDROID_KEYSTORE_BASE64 }}
17+
ANDROID_STORE_PASSWORD: ${{ secrets.ANDROID_STORE_PASSWORD }}
18+
ANDROID_KEY_ALIAS: ${{ secrets.ANDROID_KEY_ALIAS }}
19+
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD }}
1520

1621
steps:
1722
- name: Checkout
@@ -32,23 +37,23 @@ jobs:
3237
run: flutter pub get
3338

3439
- name: Configure Android signing
35-
if: ${{ secrets.ANDROID_KEYSTORE_BASE64 != '' }}
40+
if: ${{ env.ANDROID_KEYSTORE_BASE64 != '' }}
3641
shell: bash
3742
run: |
38-
echo "${{ secrets.ANDROID_KEYSTORE_BASE64 }}" | base64 --decode > android/release.keystore
43+
echo "${ANDROID_KEYSTORE_BASE64}" | base64 --decode > android/release.keystore
3944
cat > android/key.properties <<EOF
4045
storeFile=release.keystore
41-
storePassword=${{ secrets.ANDROID_STORE_PASSWORD }}
42-
keyAlias=${{ secrets.ANDROID_KEY_ALIAS }}
43-
keyPassword=${{ secrets.ANDROID_KEY_PASSWORD }}
46+
storePassword=${ANDROID_STORE_PASSWORD}
47+
keyAlias=${ANDROID_KEY_ALIAS}
48+
keyPassword=${ANDROID_KEY_PASSWORD}
4449
EOF
4550
4651
- name: Build Android release APK
47-
if: ${{ secrets.ANDROID_KEYSTORE_BASE64 != '' }}
52+
if: ${{ env.ANDROID_KEYSTORE_BASE64 != '' }}
4853
run: flutter build apk --release
4954

5055
- name: Build Android debug APK (fallback)
51-
if: ${{ secrets.ANDROID_KEYSTORE_BASE64 == '' }}
56+
if: ${{ env.ANDROID_KEYSTORE_BASE64 == '' }}
5257
run: flutter build apk --debug
5358

5459
- name: Prepare Android artifact

0 commit comments

Comments
 (0)