Skip to content

Commit 304f8c2

Browse files
packages: update webpack-dev-server to recent version
To solve an issue with GHSA-9wv6-86v2-598j bump the webpack-dev-server. This only works with a higher node version so ensure presence in CI. Signed-off-by: Jasper Berton <jasper.berton@team.blue>
1 parent 27daafb commit 304f8c2

File tree

5 files changed

+488
-270
lines changed

5 files changed

+488
-270
lines changed

.github/workflows/check.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,11 @@ jobs:
6464
steps:
6565
- name: Install yarn (online mode does not use ovirt-engine-nodejs-modules so yarn isn't installed)
6666
run: |
67-
dnf -y install nodejs
67+
if dnf module list nodejs &>/dev/null 2>&1; then
68+
dnf -y module reset nodejs
69+
dnf -y module enable nodejs:20
70+
dnf -y install nodejs
71+
fi
6872
dnf -y config-manager --add-repo https://dl.yarnpkg.com/rpm/yarn.repo
6973
dnf -y --disablerepo='*' --enablerepo='yarn*' install yarn
7074

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,6 @@ mocker-*.cfg
4343

4444
# Not autogenerated!
4545
\!.copr/Makefile
46+
47+
# autogenerated configure script
48+
configure~

config/webpack.config.dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default ({
2929
devServer: {
3030
host,
3131
port,
32-
https,
32+
server: https ? 'https' : 'http',
3333
historyApiFallback: {
3434
index: publicPath,
3535
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"terser-webpack-plugin": "5.3.1",
5555
"webpack": "5.72.0",
5656
"webpack-cli": "4.9.1",
57-
"webpack-dev-server": "4.8.1",
57+
"webpack-dev-server": "^4.15.1",
5858
"webpack-merge": "5.8.0"
5959
},
6060
"dependencies": {

0 commit comments

Comments
 (0)