Conversation
dupondje
force-pushed
the
fix_qos_update
branch
3 times, most recently
from
2943bff to
576c950
Compare
Since commit 50cd770, vdsm uses the old bandwidth value when updating (the QoS) on the NIC. Now lets say we have the following active on a VM NIC: <bandwidth> <inbound average="128000" peak="384000" burst="1024000" /> <outbound average="128000" burst="1024000" peak="384000" /> </bandwidth> And we pass the following update from the engine: <bandwidth> <outbound average="128000" burst="1024000" peak="384000"/> </bandwidth> Then it will preserve the inbound QoS, which is not something we want. This is a leftover from pre 'libvirt XML' oVirt era. Cause before it needed an empty 'inbound' tag to remove the inbound QoS. See the notes in the above commit: 'It is deleted if it is in specParams but empty ({'inbound':{}}).' But as the complete XML is now passed to vdsm, we can just rely on the data coming from the engine, without the need to parse the old bandwidth data. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
dupondje
force-pushed
the
fix_qos_update
branch
from
576c950 to
a9d9009
Compare
JasperB-TeamBlue
approved these changes
Oct 31, 2025
peter-boden
approved these changes
Oct 31, 2025
Member
Author
|
/ost |
|
⏳ Running ost suite 'basic-suite-master' on distro 'el9stream'. Follow the progress here. |
|
😎💪 ost suite 'basic-suite-master' on distro 'el9stream' finished successfully. (details) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 50cd770, vdsm uses the old bandwidth value when updating (the QoS) on the NIC.
Now lets say we have the following active on a VM NIC:
And we pass the following update from the engine:
Then it will preserve the inbound QoS, which is not something we want.
This is a leftover from pre 'libvirt XML' oVirt era. Cause before it needed an empty 'inbound' tag to make the inbound QoS to get removed. See the notes in the above commit:
'It is deleted if it is in specParams but empty ({'inbound':{}}).'
But as the complete XML is now passed to vdsm, we can just rely on the data coming from the engine, without the need to parse the old bandwidth data.