Merge pull request #16 from oalders/copilot/fix-debounce-functionality

Fix cache directory creation when ~/.cache/debounce doesn't exist

Author: oalders

go.sum

@@ -1,10 +1,13 @@
 github.com/alecthomas/assert/v2 v2.10.0 h1:jjRCHsj6hBJhkmhznrCzoNpbA3zqy0fYiUcYZP/GkPY=
+github.com/alecthomas/assert/v2 v2.10.0/go.mod h1:Bze95FyfUr7x34QZrjL+XP+0qgp/zg8yS+TtBj1WA3k=
 github.com/alecthomas/kong v1.2.1 h1:E8jH4Tsgv6wCRX2nGrdPyHDUCSG83WH2qE4XLACD33Q=
 github.com/alecthomas/kong v1.2.1/go.mod h1:rKTSFhbdp3Ryefn8x5MOEprnRFQ7nlmMC01GKhehhBM=
 github.com/alecthomas/repr v0.4.0 h1:GhI2A8MACjfegCPVq9f1FLvIBS+DrQ2KQBFZP1iFzXc=
+github.com/alecthomas/repr v0.4.0/go.mod h1:Fr0507jx4eOXV7AlPV6AVZLYrLIuIeSOWtW57eE/O/4=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/hexops/gotextdiff v1.0.3 h1:gitA9+qJrrTCsiCl7+kh75nPqQt1cx4ZkudSTLoUqJM=
+github.com/hexops/gotextdiff v1.0.3/go.mod h1:pSWU5MAI3yDq+fZBTazCSJysOMbxWL1BSow5/V2vxeg=
 github.com/oalders/is v0.5.4-0.20240716215244-33e0acf2ac19 h1:9BaO8F7ovJseyo119hfahMm1UDU98/cEQ2LN8m+TCmY=
 github.com/oalders/is v0.5.4-0.20240716215244-33e0acf2ac19/go.mod h1:11gTLN1BHxrg8PYn+73Iuspq7kOsQVbl4ccOlj8rHj0=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=

run/run.go

@@ -37,7 +37,7 @@ func Run(args *types.DebounceCommand, home string) (bool, []byte, error) { //nol
 		}
 	} else {
 		cacheDir = filepath.Join(home, ".cache", "debounce")
-		err := MaybeMakeCacheDir(home, cacheDir)
+		err := MaybeMakeCacheDir(home, filepath.Join(".cache", "debounce"))
 		if err != nil {
 			return false, []byte{}, err
 		}

run/run_test.go

@@ -2,7 +2,7 @@ package run_test
 
 import (
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 
 	"github.com/oalders/debounce/run"
@@ -43,7 +43,7 @@ func TestEnsureDir(t *testing.T) {
 	err = run.MaybeMakeCacheDir(tempDir, dirName)
 	require.NoError(t, err, "first attempt to make dir")
 
-	_, err = os.Stat(path.Join(tempDir, dirName))
+	_, err = os.Stat(filepath.Join(tempDir, dirName))
 	require.NoError(t, err)
 
 	err = run.MaybeMakeCacheDir(tempDir, dirName)
@@ -76,3 +76,35 @@ func TestRunWithNonExistentCacheDir(t *testing.T) {
 	assert.False(t, success)
 	assert.Empty(t, output)
 }
+
+func TestRunCreatesDefaultCacheDir(t *testing.T) {
+	t.Parallel()
+	// Create a temporary home directory
+	tempHome, err := os.MkdirTemp("", "test-home")
+	require.NoError(t, err)
+	defer os.RemoveAll(tempHome)
+
+	// Don't create the cache dir ahead of time - let Run create it
+	args := &types.DebounceCommand{
+		Quantity: "1",
+		Unit:     "s",
+		Command:  []string{"echo", "Hello, World!"},
+		Debug:    false,
+	}
+
+	// Run should succeed even when cache dir doesn't exist
+	success, output, err := run.Run(args, tempHome)
+	assert.NoError(t, err)
+	assert.True(t, success)
+	assert.Equal(t, string(output), "Hello, World!\n")
+
+	// Verify the cache directory was created
+	cacheDir := filepath.Join(tempHome, ".cache", "debounce")
+	_, err = os.Stat(cacheDir)
+	assert.NoError(t, err, "cache directory should be created")
+
+	// Verify the cache file was created
+	entries, err := os.ReadDir(cacheDir)
+	require.NoError(t, err)
+	assert.Len(t, entries, 1, "should have created one cache file")
+}