"Detected custom leapp actors or files" for (old?) .pyc files

[evgeni]

Actual behavior
I ran leapp preupgrade on an EL8 box and got the following report:

Title: Detected custom leapp actors or files.
Summary: We have detected installed custom actors or files on the system. These can be provided e.g. by third party vendors, Red Hat consultants, or can be created by users to customize the upgrade (e.g. to migrate custom applications). This is allowed and appreciated. However Red Hat is not responsible for any issues caused by these custom leapp actors. Note that upgrade tooling is under agile development which could require more frequent update of custom actors.
The list of custom leapp actors and files:
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/checknonmountboots390/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/checknonmountboots390/libraries/__pycache__/checknonmountboots390.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/efibootorderfix/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/inhibitwhenluks/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/localreposinhibit/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/peseventsscanner/libraries/__pycache__/peseventsscanner.cpython-36.pyc (Actor: pes_events_scanner)
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/redhatsignedrpmscanner/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/restrictedpcisscanner/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/actors/restrictedpcisscanner/libraries/__pycache__/restrictedpcisscanner.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/common/models/__pycache__/grubdevice.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/authselectapply/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/authselectcheck/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/authselectscanner/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/authselectscanner/libraries/__pycache__/authselectscanner.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkacpid/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkbrltty/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkbrltty/libraries/__pycache__/checkbrltty.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkbtrfs/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkchrony/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkchrony/libraries/__pycache__/checkchrony.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkcifs/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkcifs/libraries/__pycache__/checkcifs.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkcpu/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkcpu/libraries/__pycache__/cpu.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkdosfstools/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkfirewalld/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkfirewalld/libraries/__pycache__/private.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkfstabxfsoptions/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkfstabxfsoptions/libraries/__pycache__/checkfstabxfsoptions.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkgrep/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkhacluster/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkhacluster/libraries/__pycache__/checkhacluster.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkipaserver/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkipaserver/libraries/__pycache__/checkipaserver.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkirssi/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkkdeapps/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkkdeapps/libraries/__pycache__/checkkdeapps.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkkdegnome/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkkdegnome/libraries/__pycache__/checkkdegnome.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkleftoverpackages/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmemcached/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmemcached/libraries/__pycache__/checkmemcached.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmemory/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmemory/libraries/__pycache__/checkmemory.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmultiplepackageversions/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkmultiplepackageversions/libraries/__pycache__/checkmultiplepackageversions.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkntp/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkntp/libraries/__pycache__/checkntp.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkpcidrivers/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkpcidrivers/libraries/__pycache__/checkpcidrivers.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkpostfix/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkremovedenvvars/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkremovedenvvars/libraries/__pycache__/checkremovedenvvars.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkremovedpammodules/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checksaphana/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checksaphana/libraries/__pycache__/checksaphana.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checksendmail/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checksendmail/libraries/__pycache__/checksendmail.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/checkwireshark/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/cupsfiltersmigrate/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/cupsfiltersmigrate/libraries/__pycache__/cupsfiltersmigrate.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/detectgrubconfigerror/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/detectgrubconfigerror/libraries/__pycache__/scanner.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/firewalldfactsactor/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/firewalldfactsactor/libraries/__pycache__/firewalldfactsactor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/firewalldupdatelockdownwhitelist/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/firewalldupdatelockdownwhitelist/libraries/__pycache__/firewalldupdatelockdownwhitelist.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/grubdevname/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/grubdevname/libraries/__pycache__/grubdevname.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/ipascanner/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/ipascanner/libraries/__pycache__/ipascanner.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkinstalleddebugkernels/checkinstalleddebugkernels/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkinstalleddebugkernels/checkinstalleddebugkernels/libraries/__pycache__/checkinstalleddebugkernels.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkinstalleddevelkernels/checkinstalleddevelkernels/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkinstalleddevelkernels/checkinstalleddevelkernels/libraries/__pycache__/checkinstalleddevelkernels.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkkerneldrivers/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/kernel/checkkerneldrivers/libraries/__pycache__/checkkerneldrivers.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratebrltty/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratebrltty/libraries/__pycache__/migratebrltty.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratentp/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratentp/libraries/__pycache__/migratentp.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratesendmail/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/migratesendmail/libraries/__pycache__/migratesendmail.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfcheck/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfcheck/libraries/__pycache__/multipathconfcheck.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfread/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfread/libraries/__pycache__/multipathconfread.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfupdate/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/multipathconfupdate/libraries/__pycache__/multipathconfupdate.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/networkmanagerreadconfig/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/networkmanagerreadconfig/libraries/__pycache__/networkmanagerreadconfig.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/networkmanagerupdateconfig/__pycache__/actor.cpython-36.pyc
    - /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/networkmanagerupdateconnections/__pycache__/actor.cpython-36.pyc
…

As you can see, most are 7to8 specific, and there are no corresponding .py files on my system, so I guess this is from a previous 7to8 upgrade

To Reproduce
Steps to reproduce the behavior

1. install RHEL7
2. upgrade to RHEL8
3. try to upgrade to RHEL9
4. see above

Expected behavior
No warnings :)

System information (please complete the following information):

• OS and version: (e.g. Fedora 29 or $ cat /etc/system-release): RHEL8.10
• # uname -a: Linux system.example.com 4.18.0-553.44.1.el8_10.x86_64 #1 SMP Wed Mar 5 10:48:41 EST 2025 x86_64 x86_64 x86_64 GNU/Linux
• # rpm -qa "*leapp*" (or shorthashes of commits in case of manual installation):

# rpm -qa "leapp*"
leapp-upgrade-el8toel9-0.22.0-1.el8_10.noarch
leapp-deps-0.19.0-1.el8_10.noarch
leapp-upgrade-el8toel9-deps-0.22.0-1.el8_10.noarch
leapp-0.19.0-1.el8_10.noarch
python3-leapp-0.19.0-1.el8_10.noarch

Additional context
Add any other context about the problem here.

[pirat89]

@evgeni btw, what RPMs did you use for IPU 7 -> 8? I am aware this problem existed years ago but it should be covered, so I am just curious how it happened. the same could potentially happened when performing 8 -> 9 -> 10 if it is not fixed still.

[evgeni]

My friend, this was upgraded years ago to EL8, I don't remember 😅

leapp-0.13.0-1.el7_9, can that be? March 2022.

[pirat89]

Aaaaah. Oki, that explains why it's happening again :) I was afraid it's a regression. This has been fixed in 2023: https://github.com/oamg/leapp-repository/releases/tag/v0.18.0 - #1017 - so I think we can close it without problems, but I will rather run it to be sure. I've seen a similar report recently from a customer and nobody confirmed the previous IPU 7 -> 8 yet. So we will try it just to be sure before closing it.

[evgeni]

But wouldn't it be cleaner (from the user PoV), if those would be ignored by the "new" leapp instead of relying on the "old" leapp not to create them?

On the other hand, getting a fix into el8 at this point is probably complicated, and if this is fixed for newer upgrades…

[pirat89]

Well, you can only ignore ALL pyc & pyo files or accept them. nothing between AFAIK. In case that many users are affected, we could add instruction to the official documentation for the removal of previous upgrade artifacts.