fix(cmd/rofl): Properly normalize ORC filenames

Author: kostko

cmd/rofl/common/manifest.go

@@ -2,6 +2,8 @@ package common
 
 import (
 	"fmt"
+	"regexp"
+	"strings"
 
 	"github.com/spf13/cobra"
 
@@ -10,6 +12,14 @@ import (
 	cliConfig "github.com/oasisprotocol/cli/config"
 )
 
+var (
+	// orcFilenameDisallowedChars is a regexp matching characters that are not allowed in filenames.
+	orcFilenameDisallowedChars = regexp.MustCompile("[^a-zA-Z0-9-]")
+
+	// orcFilenameRepeatedChars is a regexp matching repeats of dash characters in filenames.
+	orcFilenameRepeatedChars = regexp.MustCompile("(-){2,}")
+)
+
 // ManifestOptions configures the manifest options.
 type ManifestOptions struct {
 	// NeedAppID specifies whether a configured app ID is required in the manifest.
@@ -98,5 +108,9 @@ func MaybeLoadManifestAndSetNPA(cfg *cliConfig.Config, npa *common.NPASelection,
 
 // GetOrcFilename generates a filename based on the project name and deployment.
 func GetOrcFilename(manifest *rofl.Manifest, deploymentName string) string {
-	return fmt.Sprintf("%s.%s.orc", manifest.Name, deploymentName)
+	normalizedName := strings.ToLower(manifest.Name)
+	normalizedName = strings.TrimSpace(normalizedName)
+	normalizedName = orcFilenameDisallowedChars.ReplaceAllString(normalizedName, "-")
+	normalizedName = orcFilenameRepeatedChars.ReplaceAllString(normalizedName, "$1")
+	return fmt.Sprintf("%s.%s.orc", normalizedName, deploymentName)
 }

cmd/rofl/common/manifest_test.go

@@ -0,0 +1,27 @@
+package common
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/oasisprotocol/cli/build/rofl"
+)
+
+func TestGetOrcFilename(t *testing.T) {
+	require := require.New(t)
+
+	for _, tc := range []struct {
+		name       string
+		deployment string
+		expected   string
+	}{
+		{"rofl-scheduler", "mainnet", "rofl-scheduler.mainnet.orc"},
+		{"ROFL Scheduler", "mainnet", "rofl-scheduler.mainnet.orc"},
+		{"   This is a    test   ", "mainnet", "this-is-a-test.mainnet.orc"},
+	} {
+		manifest := &rofl.Manifest{Name: tc.name}
+		fn := GetOrcFilename(manifest, "mainnet")
+		require.Equal(tc.expected, fn)
+	}
+}