fix: use string instead due to -X limitations

njelich · njelich · commit dc9450de95e6 · 2025-08-08T14:08:10.000+02:00
diff --git a/cmd/update.go b/cmd/update.go
@@ -59,7 +59,7 @@ var (
 	githubAPIBase = "https://api.github.com"
 	download      = doDownload
 	osExecutable  = os.Executable
-	disableUpdateSubcommand = false
+	disableUpdateSubcommand = "false"
 )
 
 // semverDiffers reports whether versions a and b differ (ignoring leading 'v').
@@ -506,7 +506,8 @@ then downloads and replaces the current binary.`,
 }
 
 func init() {
-	if disableUpdateSubcommand {
+	// I have to use a string here because of the limitations of the -X flag in Go build.
+	if disableUpdateSubcommand == "true" {
 		return
 	}
 	updateCmd.Flags().AddFlagSet(progress.AnswerYesFlag)

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ var (`
`59`	`59`	`githubAPIBase = "https://api.github.com"`
`60`	`60`	`download = doDownload`
`61`	`61`	`osExecutable = os.Executable`
`62`		`- disableUpdateSubcommand = false`
	`62`	`+ disableUpdateSubcommand = "false"`
`63`	`63`	`)`
`64`	`64`
`65`	`65`	`// semverDiffers reports whether versions a and b differ (ignoring leading 'v').`
@@ -506,7 +506,8 @@ then downloads and replaces the current binary.`,
`506`	`506`	`}`
`507`	`507`
`508`	`508`	`func init() {`
`509`		`- if disableUpdateSubcommand {`
	`509`	`+ // I have to use a string here because of the limitations of the -X flag in Go build.`
	`510`	`+ if disableUpdateSubcommand == "true" {`
`510`	`511`	`return`
`511`	`512`	`}`
`512`	`513`	`updateCmd.Flags().AddFlagSet(progress.AnswerYesFlag)`