Merge pull request #1904 from oasisprotocol/lw/partial-external-test

Test partial external URLs by filling them in

Author: lukaw3d

.changelog/1904.trivial.md

@@ -0,0 +1 @@
+Test partial external URLs by filling them in

src/app/utils/__tests__/externalLinks.test.ts

@@ -27,16 +27,24 @@ onlyRunOnCI('externalLinks', () => {
   describe('should be reachable', () => {
     const { reddit, twitter } = externalLinksModule.socialMedia
     for (const [linksGroupName, linksGroup] of Object.entries(externalLinksModule)) {
-      for (const [linkName, url] of Object.entries(linksGroup)) {
+      for (const [linkName, originalUrl] of Object.entries(linksGroup)) {
+        let url = originalUrl
         if (!url || typeof url !== 'string') continue
         if (!!reddit && url.startsWith(reddit)) continue // Reddit often returns 504
         if (!!twitter && url.startsWith(twitter)) continue // redirect loop
         if (url.startsWith(externalLinksModule.referrals.coinGecko)) continue // CoinGecko has CloudFlare DDOS protection
-        if (url.startsWith(externalLinksModule.github.commit)) continue // We store only partial url in constants
-        if (url.startsWith(externalLinksModule.github.releaseTag)) continue // We store only partial url in constants
-        if (url.startsWith(externalLinksModule.ipfs.proxyPrefix)) continue // We store only partial url in constants
         if (url.startsWith('mailto')) continue // We can't test email addresses
 
+        if (url.startsWith(externalLinksModule.github.commit)) {
+          url += '904840745dde1a5dfff6608213e50dfa4d4ee7c8'
+        }
+        if (url.startsWith(externalLinksModule.github.releaseTag)) {
+          url += 'v1.2.0'
+        }
+        if (url.startsWith(externalLinksModule.ipfs.proxyPrefix)) {
+          url += 'bafybeifx7yeb55armcsxwwitkymga5xf53dxiarykms3ygqic223w5sk3m'
+        }
+
         it.concurrent(`${linksGroupName} ${linkName} ${url}`, async () => {
           const response = await nodeFetch(url, { method: 'GET' })
           expect(response.status).toBe(200)