Merge pull request #2420 from oasisprotocol/mz/lintWarnings-2

Fix lint warnings around components

Author: buberdds

.changelog/2420.trivial.md

@@ -0,0 +1 @@
+Fix lint warnings around components

src/app/components/AccountList/index.tsx

@@ -1,6 +1,7 @@
 import { FC } from 'react'
 import { useTranslation } from 'react-i18next'
-import { Table, TableCellAlign, TableColProps } from '../../components/Table'
+import { Table, TableColProps } from '../../components/Table'
+import { TableCellAlign } from '../../components/Table/types'
 import { RoundedBalance } from '../../components/RoundedBalance'
 import { Account } from '../../../oasis-nexus/api'
 import { TablePaginationProps } from '../Table/TablePagination'

src/app/components/Blocks/ConsensusBlocks.tsx

@@ -1,6 +1,7 @@
 import { useTranslation } from 'react-i18next'
 import { Block, EntityMetadata } from '../../../oasis-nexus/api'
-import { Table, TableCellAlign, TableColProps } from '../../components/Table'
+import { Table, TableColProps } from '../../components/Table'
+import { TableCellAlign } from '../../components/Table/types'
 import { TablePaginationProps } from '../Table/TablePagination'
 import { BlockHashLink, BlockLink } from './BlockLink'
 import { useScreenSize } from '../../hooks/useScreensize'

src/app/components/Blocks/RecentBlocks.tsx

@@ -6,7 +6,8 @@ import { RecentBlock } from '../../../oasis-nexus/api'
 import { useScreenSize } from '../../hooks/useScreensize'
 import { getLayerLabels } from '../../utils/content'
 import { RouteUtils } from '../../utils/route-utils'
-import { Table, TableCellAlign, TableColProps } from '../Table'
+import { Table, TableColProps } from '../Table'
+import { TableCellAlign } from '../Table/types'
 import { TableCellAge } from '../TableCellAge'
 import { TableHeaderAge } from '../TableHeaderAge'
 import { BlockHashLink, BlockLink } from './BlockLink'

src/app/components/Blocks/RuntimeBlocks.tsx

@@ -1,12 +1,13 @@
 import { useTranslation } from 'react-i18next'
 import { RuntimeBlock } from '../../../oasis-nexus/api'
-import { Table, TableCellAlign, TableColProps } from '../../components/Table'
+import { Table, TableColProps } from '../../components/Table'
+import { TableCellAlign } from '../../components/Table/types'
 import { paraTimesConfig } from '../../../config'
 import { TablePaginationProps } from '../Table/TablePagination'
 import { BlockHashLink, BlockLink } from './BlockLink'
 import { useScreenSize } from '../../hooks/useScreensize'
 import { FC } from 'react'
-import { BlocksTableType } from './index'
+import { BlocksTableType } from './types'
 import { TableHeaderAge } from '../TableHeaderAge'
 import { TableCellAge } from '../TableCellAge'
 import { Progress } from '@oasisprotocol/ui-library/src/components/progress'

src/app/components/Blocks/index.tsx

@@ -0,0 +1,5 @@
+export enum BlocksTableType {
+  Mobile,
+  DesktopLite,
+  Desktop,
+}

src/app/components/Blocks/types.tsx

@@ -3,67 +3,14 @@ import { useTranslation } from 'react-i18next'
 import { ConsensusEvent, ConsensusEventType } from '../../../oasis-nexus/api'
 import { ConsensusScope } from '../../../types/searchScope'
 import { TransactionLink } from '../Transactions/TransactionLink'
-import { TFunction } from 'i18next'
-import { exhaustedTypeWarning } from '../../../types/errors'
 import { MethodIcon } from '../ConsensusTransactionMethod'
 import { ArrowRight, CopyCheck, LogOut } from 'lucide-react'
 import { StyledDescriptionList } from '../StyledDescriptionList'
 import { AccountLink } from '../Account/AccountLink'
 import { getPreciseNumberFormat } from '../../../locales/getPreciseNumberFormat'
 import { getTokensForScope } from '../../../config'
 import { RoundedBalance } from '../RoundedBalance'
-
-export const getConsensusEventTypeLabel = (t: TFunction, type: ConsensusEventType | undefined): string => {
-  switch (type) {
-    case 'governance.proposal_executed':
-      return t('consensusEvent.governanceProposalExecuted')
-    case 'governance.proposal_finalized':
-      return t('consensusEvent.governanceProposalFinalized')
-    case 'governance.proposal_submitted':
-      return t('consensusEvent.governanceProposalSubmitted')
-    case 'governance.vote':
-      return t('consensusEvent.governanceVote')
-    case 'registry.entity':
-      return t('consensusEvent.registryEntity')
-    case 'registry.node':
-      return t('consensusEvent.registryNode')
-    case 'registry.node_unfrozen':
-      return t('consensusEvent.registryNodeUnfrozen')
-    case 'registry.runtime':
-      return t('consensusEvent.registryRuntime')
-    case 'registry.runtime_suspended':
-      return t('consensusEvent.registryRuntimeSuspended')
-    case 'roothash.execution_discrepancy':
-      return t('consensusEvent.roothashExecution_discrepancy')
-    case 'roothash.executor_committed':
-      return t('consensusEvent.roothashExecutorCommitted')
-    case 'roothash.finalized':
-      return t('consensusEvent.roothashFinalized')
-    case 'roothash.in_msg_processed':
-      return t('consensusEvent.roothashInMsgProcessed')
-    case 'roothash.message':
-      return t('consensusEvent.roothashMessage')
-    case 'staking.allowance_change':
-      return t('consensusEvent.stakingAllowanceChange')
-    case 'staking.burn':
-      return t('consensusEvent.stakingBurn')
-    case 'staking.escrow.add':
-      return t('consensusEvent.stakingEscrowAdd')
-    case 'staking.escrow.debonding_start':
-      return t('consensusEvent.stakingEscrowDebondingStart')
-    case 'staking.escrow.reclaim':
-      return t('consensusEvent.stakingEscrowReclaim')
-    case 'staking.escrow.take':
-      return t('consensusEvent.stakingEscrowTake')
-    case 'staking.transfer':
-      return t('consensusEvent.stakingTransfer')
-    case undefined:
-      return t('common.unknown')
-    default:
-      exhaustedTypeWarning('Unexpected event type', type)
-      return type
-  }
-}
+import { getConsensusEventTypeLabel } from './helpers'
 
 const ConsensusEventDetailsContent: FC<{
   event: ConsensusEvent

src/app/components/ConsensusEvents/ConsensusEventDetails.tsx

@@ -5,7 +5,7 @@ import { ConsensusEventFilteringType } from '../../hooks/useCommonParams'
 import { TFunction } from 'i18next'
 import { paraTimesConfig } from '../../../config'
 import { ParamSetterFunction } from '../../hooks/useTypedSearchParam'
-import { getConsensusEventTypeLabel } from './ConsensusEventDetails'
+import { getConsensusEventTypeLabel } from './helpers'
 import { FilterByType } from '../FilterByType'
 
 type Option = {

src/app/components/ConsensusEvents/ConsensusEventTypeFilter.tsx

@@ -0,0 +1,55 @@
+import { ConsensusEventType } from '../../../oasis-nexus/api'
+import { TFunction } from 'i18next'
+import { exhaustedTypeWarning } from '../../../types/errors'
+
+export const getConsensusEventTypeLabel = (t: TFunction, type: ConsensusEventType | undefined): string => {
+  switch (type) {
+    case 'governance.proposal_executed':
+      return t('consensusEvent.governanceProposalExecuted')
+    case 'governance.proposal_finalized':
+      return t('consensusEvent.governanceProposalFinalized')
+    case 'governance.proposal_submitted':
+      return t('consensusEvent.governanceProposalSubmitted')
+    case 'governance.vote':
+      return t('consensusEvent.governanceVote')
+    case 'registry.entity':
+      return t('consensusEvent.registryEntity')
+    case 'registry.node':
+      return t('consensusEvent.registryNode')
+    case 'registry.node_unfrozen':
+      return t('consensusEvent.registryNodeUnfrozen')
+    case 'registry.runtime':
+      return t('consensusEvent.registryRuntime')
+    case 'registry.runtime_suspended':
+      return t('consensusEvent.registryRuntimeSuspended')
+    case 'roothash.execution_discrepancy':
+      return t('consensusEvent.roothashExecution_discrepancy')
+    case 'roothash.executor_committed':
+      return t('consensusEvent.roothashExecutorCommitted')
+    case 'roothash.finalized':
+      return t('consensusEvent.roothashFinalized')
+    case 'roothash.in_msg_processed':
+      return t('consensusEvent.roothashInMsgProcessed')
+    case 'roothash.message':
+      return t('consensusEvent.roothashMessage')
+    case 'staking.allowance_change':
+      return t('consensusEvent.stakingAllowanceChange')
+    case 'staking.burn':
+      return t('consensusEvent.stakingBurn')
+    case 'staking.escrow.add':
+      return t('consensusEvent.stakingEscrowAdd')
+    case 'staking.escrow.debonding_start':
+      return t('consensusEvent.stakingEscrowDebondingStart')
+    case 'staking.escrow.reclaim':
+      return t('consensusEvent.stakingEscrowReclaim')
+    case 'staking.escrow.take':
+      return t('consensusEvent.stakingEscrowTake')
+    case 'staking.transfer':
+      return t('consensusEvent.stakingTransfer')
+    case undefined:
+      return t('common.unknown')
+    default:
+      exhaustedTypeWarning('Unexpected event type', type)
+      return type
+  }
+}