Merge pull request #1073 from oasisprotocol/ptrus/fix/consensus-fetchtimer

analyzer/consensus: Record timing only for successful requests

Author: ptrus

.changelog/1073.bugfix.md

@@ -0,0 +1 @@
+analyzer/consensus: Record timing only for successful requests

analyzer/consensus/consensus.go

@@ -348,10 +348,11 @@ func (m *processor) ProcessBlock(ctx context.Context, uheight uint64) error {
 		// Fetch all data.
 		fetchTimer := m.metrics.BlockFetchLatencies()
 		data, err := fetchAllData(ctx, m.source, m.network, height, m.mode == analyzer.FastSyncMode)
-		fetchTimer.ObserveDuration()
 		if err != nil {
 			return err
 		}
+		// We make no observation in case of a data fetch error; those timings are misleading.
+		fetchTimer.ObserveDuration()
 
 		// Process data, prepare updates.
 		analysisTimer := m.metrics.BlockAnalysisLatencies()

analyzer/runtime/runtime.go

@@ -256,8 +256,8 @@ func (m *processor) ProcessBlock(ctx context.Context, round uint64) error {
 	if err != nil {
 		return err
 	}
-
-	fetchTimer.ObserveDuration() // We make no observation in case of a data fetch error; those timings are misleading.
+	// We make no observation in case of a data fetch error; those timings are misleading.
+	fetchTimer.ObserveDuration()
 
 	// Preprocess data.
 	analysisTimer := m.metrics.BlockAnalysisLatencies()