Merge pull request #1064 from oasisprotocol/ptrus/fix/roflmarket-instances-fix

storage/roflmarket_instances: Remove invalid FK

Author: ptrus

storage/migrations/25_runtime_roflmarket.up.sql

@@ -65,8 +65,7 @@ CREATE TABLE chain.roflmarket_instances (
   FOREIGN KEY (runtime, provider) REFERENCES chain.roflmarket_providers(runtime, address) DEFERRABLE INITIALLY DEFERRED,
 
   offer_id BYTEA NOT NULL,
-  FOREIGN KEY (runtime, offer_id) REFERENCES chain.roflmarket_offers(runtime, id) DEFERRABLE INITIALLY DEFERRED, -- Removed in 40_runtime_roflmarket_constraints_fix.up.sql.
-  -- FOREIGN KEY (runtime, provider, offer_id) REFERENCES chain.roflmarket_offers(runtime, provider, id) DEFERRABLE INITIALLY DEFERRED, -- Added in 40_runtime_roflmarket_constraints_fix.up.sql.
+  FOREIGN KEY (runtime, offer_id) REFERENCES chain.roflmarket_offers(runtime, id) DEFERRABLE INITIALLY DEFERRED, -- Removed in 40_runtime_roflmarket_constraints_fix.up.sql. Offer can be removed, but instance still exists.
 
   status SMALLINT CHECK  (status >= 0 AND status <= 255),
   creator oasis_addr,

storage/migrations/40_runtime_roflmarket_constraints_fix.up.sql

@@ -18,13 +18,6 @@ ALTER TABLE chain.roflmarket_offers
 ALTER TABLE chain.roflmarket_instances
   ADD PRIMARY KEY (runtime, provider, id);
 
--- Add new FKs with provider included.
-ALTER TABLE chain.roflmarket_instances
-  ADD CONSTRAINT roflmarket_instances_runtime_provider_offer_id_fkey
-  FOREIGN KEY (runtime, provider, offer_id)
-  REFERENCES chain.roflmarket_offers(runtime, provider, id)
-  DEFERRABLE INITIALLY DEFERRED;
-
 -- Drop unneded index with the new PKs.
 DROP INDEX IF EXISTS chain.ix_roflmarket_offers_provider;
 DROP INDEX IF EXISTS chain.ix_roflmarket_instances_provider;