Fixup: Move advertisement out of topic registration

Author: martintomazic

go/p2p/p2p.go

@@ -306,6 +306,7 @@ func (p *p2p) RegisterHandler(topic string, handler api.Handler) {
 	)
 
 	p.peerMgr.RegisterTopic(topic, minTopicPeers, totalTopicPeers)
+	p.peerMgr.AdvertiseProtocol(topic)
 }
 
 // Implements api.Service.
@@ -340,7 +341,7 @@ func (p *p2p) RegisterProtocolServer(srv rpc.Server) {
 
 	p.host.SetStreamHandler(srv.Protocol(), srv.HandleStream)
 
-	p.peerMgr.AdvertiseProtocol(srv.Protocol())
+	p.peerMgr.AdvertiseProtocol(string(srv.Protocol()))
 
 	p.logger.Info("registered protocol server",
 		"protocol_id", srv.Protocol(),

go/p2p/peermgmt/peermgr.go

@@ -198,8 +198,8 @@ func (m *PeerManager) RegisterProtocol(p core.ProtocolID, minPeers int, totalPee
 // AdvertiseProtocol starts advertising readiness to serve the specified protocol.
 //
 // This enables remote peers without existing connection to find the host node.
-func (m *PeerManager) AdvertiseProtocol(p core.ProtocolID) {
-	m.discovery.startAdvertising(string(p))
+func (m *PeerManager) AdvertiseProtocol(p string) {
+	m.discovery.startAdvertising(p)
 }
 
 // RegisterTopic starts tracking and managing peers that support the given topic.
@@ -222,7 +222,6 @@ func (m *PeerManager) RegisterTopic(topic string, minPeers int, totalPeers int)
 	}
 
 	m.topics[topic] = &watermark{minPeers, totalPeers}
-	m.discovery.startAdvertising(topic)
 
 	m.logger.Debug("topic registered",
 		"topic", topic,