runtime-sdk/modules/rofl-market: Decrement instances count on cancel

Author: peternose

runtime-sdk/modules/rofl-market/src/lib.rs

@@ -677,7 +677,7 @@ impl<Cfg: Config> Module<Cfg> {
             return Ok(());
         }
 
-        let provider = state::get_provider(body.provider).ok_or(Error::ProviderNotFound)?;
+        let mut provider = state::get_provider(body.provider).ok_or(Error::ProviderNotFound)?;
         let mut instance =
             state::get_instance(body.provider, body.id).ok_or(Error::InstanceNotFound)?;
         Self::ensure_caller_is_instance_admin(&instance)?;
@@ -694,6 +694,14 @@ impl<Cfg: Config> Module<Cfg> {
                 // We can also directly remove the instance.
                 state::remove_instance(body.provider, body.id);
 
+                // Update provider metadata.
+                provider.instances_count = provider
+                    .instances_count
+                    .checked_sub(1)
+                    .ok_or(Error::InvalidArgument)?;
+                provider.updated_at = ctx.now();
+                state::set_provider(provider);
+
                 CurrentState::with(|state| {
                     state.emit_event(Event::InstanceRemoved {
                         provider: body.provider,

runtime-sdk/modules/rofl-market/src/test.rs

@@ -1199,6 +1199,33 @@ fn test_instance_accept_timeout() {
     assert_eq!(balance, 0);
     let balance = Accounts::get_balance(keys::charlie::address(), Denomination::NATIVE).unwrap();
     assert_eq!(balance, 1_000_000);
+
+    // Instance should be removed.
+    let instances: Vec<types::Instance> = signer_alice
+        .query(
+            &ctx,
+            "roflmarket.Instances",
+            types::ProviderQuery {
+                provider: keys::alice::address(),
+            },
+        )
+        .unwrap();
+    assert_eq!(instances.len(), 0, "instance should be removed");
+
+    // Provider should have no instances.
+    let provider: types::Provider = signer_alice
+        .query(
+            &ctx,
+            "roflmarket.Provider",
+            types::ProviderQuery {
+                provider: keys::alice::address(),
+            },
+        )
+        .unwrap();
+    assert_eq!(
+        provider.instances_count, 0,
+        "provider should have no instances"
+    );
 }
 
 #[test]