fix(rofl-client): default encrypt to true in Python client

Author: uniyalabhishek

rofl-client/py/README.md

@@ -75,15 +75,15 @@ Fetches or generates a cryptographic key from ROFL.
 - **Returns:** The private key as a hex string
 - **Raises:** `httpx.HTTPStatusError` if the request fails
 
-##### `async sign_submit(tx: TxParams, encrypt: bool = False) -> dict[str, Any]`
+##### `async sign_submit(tx: TxParams, encrypt: bool = True) -> dict[str, Any]`
 
 Sign the given Ethereum transaction with an endorsed ephemeral key and submit it to Sapphire.
 
 Note: Transaction nonce and gas price are ignored.
 
 - **Parameters:**
     - `tx`: Transaction parameters
-    - `encrypt`: End-to-end encrypt the transaction before submitting (default: False)
+    - `encrypt`: End-to-end encrypt the transaction before submitting (default: True)
 - **Returns:** Deserialized response data object
 - **Raises:** `httpx.HTTPStatusError` if the request fails
 - **Raises:** `cbor2.CBORDecodeValueError` If the response data is invalid
@@ -125,4 +125,4 @@ Publishing to PyPI is fully automated via GitHub Actions.
 
 ## License
 
-Licensed under the Apache License, Version 2.0. See `LICENSE` for details or visit http://www.apache.org/licenses/LICENSE-2.0.
+Licensed under the Apache License, Version 2.0. See `LICENSE` for details or visit http://www.apache.org/licenses/LICENSE-2.0.

rofl-client/py/src/oasis_rofl_client/rofl_client.py

@@ -130,14 +130,14 @@ async def generate_key(
     async def sign_submit(
         self,
         tx: TxParams,
-        encrypt: bool = False,
+        encrypt: bool = True,
     ) -> dict[str, Any]:
         """Sign the given Ethereum transaction with an endorsed ephemeral key and submit it to Sapphire.
 
         Note: Transaction nonce and gas price are ignored.
 
         :param tx: Transaction parameters
-        :param encrypt: End-to-end encrypt the transaction before submitting (default: False)
+        :param encrypt: End-to-end encrypt the transaction before submitting (default: True)
         :returns: Deserialized response data object.
         :raises httpx.HTTPStatusError: If the request fails
         :raises cbor2.CBORDecodeValueError: If the response data is invalid

rofl-client/py/tests/test_client.py

@@ -299,6 +299,33 @@ async def test_sign_submit(self, mock_client_class):
             timeout=60.0,
         )
 
+    @patch("oasis_rofl_client.rofl_client.httpx.AsyncClient")
+    async def test_sign_submit_default_encrypt_true(self, mock_client_class):
+        """sign_submit should default encrypt to True when omitted."""
+        mock_response = MagicMock()
+        mock_response.json.return_value = {"data": ""}
+        mock_response.raise_for_status = MagicMock()
+
+        mock_client = AsyncMock()
+        mock_client.post.return_value = mock_response
+        mock_client_class.return_value.__aenter__.return_value = mock_client
+
+        client = RoflClient()
+        tx: TxParams = {
+            "from": "0x1234567890123456789012345678901234567890",
+            "data": "0x",
+            "gas": 21000,
+            "gasPrice": 0,
+            "value": 0,
+            "nonce": 0,
+        }
+
+        await client.sign_submit(tx)  # no encrypt argument
+
+        mock_client.post.assert_called_once()
+        _, kwargs = mock_client.post.call_args
+        assert kwargs["json"]["encrypt"] is True
+
     @patch("oasis_rofl_client.rofl_client.httpx.AsyncClient")
     async def test_get_metadata(self, mock_client_class):
         """Test get_metadata method."""

rofl-client/ts/test/client.test.ts

@@ -247,6 +247,24 @@ describe('RoflClient', () => {
         expect(payload.tx.data.data).toBe('deadbeef'); // 0x stripped
     });
 
+    it('sign-submit defaults encrypt to true when opts are omitted', async () => {
+        const calls: TransportRequest[] = [];
+        const client = makeClient(calls);
+
+        await client.signAndSubmit({
+            kind: 'eth',
+            gas_limit: 1,
+            to: '',
+            value: 0,
+            data: '0x',
+        });
+
+        const call = calls.find((c) => c.path === '/rofl/v1/tx/sign-submit')!;
+        expect(call).toBeTruthy();
+        const payload = call.payload as any;
+        expect(payload.encrypt).toBe(true);
+    });
+
     it('normalizes EthTx.value inputs precisely', async () => {
         const calls: TransportRequest[] = [];
         const client = makeClient(calls);