fix: Fix parsing of legacy transactions without chain ID

Newer go-ethereum versions reject a zero `chainID` in
`LatestSignerForChainID`. For legacy transactions without a chain ID,
we now correctly pass `nil`.

Author: ptrus

indexer/utils.go

@@ -149,7 +149,14 @@ func blockToModels(
 	for idx, ethTx := range transactions {
 		ethTxHex := ethTx.Hash().Hex()
 		v, r, s := ethTx.RawSignatureValues()
-		signer := ethtypes.LatestSignerForChainID(ethTx.ChainId())
+		chainID := ethTx.ChainId()
+		if chainID != nil && chainID.Cmp(big.NewInt(0)) == 0 {
+			// Legacy transactions don't have a chain ID but `ChainId()` returns 0, which is invalid
+			// for `LatestSignerForChainId` which expects a null in that case (zero causes a panic).
+			// https://github.com/ethereum/go-ethereum/issues/31653
+			chainID = nil
+		}
+		signer := ethtypes.LatestSignerForChainID(chainID)
 		from, _ := signer.Sender(ethTx)
 		ethAccList := ethTx.AccessList()
 		accList := make([]model.AccessTuple, 0, len(ethAccList))

tests/rpc/rpc_test.go

@@ -63,7 +63,7 @@ func call(t *testing.T, method string, params interface{}) *Response {
 }
 
 //nolint:unparam
-func submitTransaction(ctx context.Context, t *testing.T, to common.Address, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) *types.Receipt {
+func submitTransaction(ctx context.Context, t *testing.T, to common.Address, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte, legacy bool) *types.Receipt {
 	ec := localClient(t, false)
 	chainID, err := ec.ChainID(context.Background())
 	require.NoError(t, err)
@@ -81,9 +81,18 @@ func submitTransaction(ctx context.Context, t *testing.T, to common.Address, amo
 		data,
 	)
 	signer := types.LatestSignerForChainID(chainID)
+	if legacy {
+		signer = types.LatestSignerForChainID(nil)
+	}
 	signature, err := crypto.Sign(signer.Hash(tx).Bytes(), tests.TestKey1.Private)
 	require.Nil(t, err, "sign tx")
 
+	if legacy {
+		// Adjust V from {0,1} to {27,28} as required by Ethereum legacy signature format.
+		// crypto.Sign returns V in {0,1}, but legacy transactions expect V ∈ {27,28}.
+		signature[64] += 27
+	}
+
 	signedTx, err := tx.WithSignature(signer, signature)
 	require.Nil(t, err, "pack tx")
 
@@ -100,7 +109,7 @@ func submitTransaction(ctx context.Context, t *testing.T, to common.Address, amo
 func submitTestTransaction(ctx context.Context, t *testing.T) *types.Receipt {
 	data := common.FromHex("0x7f7465737432000000000000000000000000000000000000000000000000000000600057")
 	to := common.BytesToAddress(common.FromHex("0x1122334455667788990011223344556677889900"))
-	return submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data)
+	return submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data, false)
 }
 
 func TestEth_GetBalance(t *testing.T) {
@@ -209,7 +218,15 @@ func TestEth_SendRawTransaction(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), OasisBlockTimeout)
 	defer cancel()
 
-	receipt := submitTransaction(ctx, t, common.Address{1}, big.NewInt(1), GasLimit, GasPrice, nil)
+	receipt := submitTransaction(ctx, t, common.Address{1}, big.NewInt(1), GasLimit, GasPrice, nil, false)
+	require.EqualValues(t, 1, receipt.Status)
+}
+
+func TestEth_SendRawLegacyTransaction(t *testing.T) {
+	ctx, cancel := context.WithTimeout(context.Background(), OasisBlockTimeout)
+	defer cancel()
+
+	receipt := submitTransaction(ctx, t, common.Address{1}, big.NewInt(1), GasLimit, GasPrice, nil, true)
 	require.EqualValues(t, 1, receipt.Status)
 }
 
@@ -328,7 +345,7 @@ func TestEth_GetTransactionByHash(t *testing.T) {
 	input := "0x7f7465737432000000000000000000000000000000000000000000000000000000600057"
 	data := common.FromHex(input)
 	to := common.BytesToAddress(common.FromHex("0x1122334455667788990011223344556677889900"))
-	receipt := submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data)
+	receipt := submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data, false)
 	require.EqualValues(t, 1, receipt.Status)
 	require.NotNil(t, receipt)
 
@@ -361,7 +378,7 @@ func TestEth_GetTransactionByBlockAndIndex(t *testing.T) {
 	input := "0x7f7465737432000000000000000000000000000000000000000000000000000000600057"
 	data := common.FromHex(input)
 	to := common.BytesToAddress(common.FromHex("0x1122334455667788990011223344556677889900"))
-	receipt := submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data)
+	receipt := submitTransaction(ctx, t, to, big.NewInt(1), GasLimit, GasPrice, data, false)
 	require.EqualValues(t, 1, receipt.Status)
 	require.NotNil(t, receipt)