Skip to content

Layout improvements #39

@buberdds

Description

@buberdds

A few things that we can investigate in the future:

  1. remove mt-12 header margin on mobile
    Image

  2. In general our custom components should always have className prop to follow shadcn API and to make it easier to customize. For example I have to get rid of md:max-h-none from Layout component

  3. layout proposed in ROSE App has weird UX with main scroll being attached to content div not browser window. You can end up with 2 scroll bars and scrolling content exp is weird on wider screens (multiple scroll areas)

Image

  • Storybook example with sidebar has layout issues (overlap footer, header etc - it has more issues on larger viewport) and you cannot use it in your app (copy/paste).It requires some special DOM tree hierarchy and CSS classes from ROSE App?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions