AbstractGenericDao.findAll(Iterable<ID>) unusable FIX #621

Author: mathieu-lavigne

modules/jpa/src/main/java/io/oasp/module/jpa/dataaccess/base/AbstractGenericDao.java

@@ -1,5 +1,7 @@
 package io.oasp.module.jpa.dataaccess.base;
 
+import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 import javax.persistence.EntityManager;
@@ -10,6 +12,7 @@
 import javax.persistence.TypedQuery;
 import javax.persistence.criteria.CriteriaBuilder;
 import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Predicate;
 import javax.persistence.criteria.Root;
 
 import net.sf.mmm.util.entity.api.PersistenceEntity;
@@ -171,13 +174,26 @@ public List<E> findAll(Iterable<ID> ids) {
     CriteriaQuery<E> query = builder.createQuery(getEntityClass());
     Root<E> root = query.from(getEntityClass());
     query.select(root);
-    query.where(root.get("id").in(ids));
+    query.where(root.get("id").in(toCollection(ids)));
     TypedQuery<E> typedQuery = getEntityManager().createQuery(query);
     List<E> resultList = typedQuery.getResultList();
     LOG.debug("Query for selection of {} objects returned {} hit(s).", getEntityName(), resultList.size());
     return resultList;
   }
 
+  /**
+   * @param ids sequence of id
+   * @return a collection of these ids to use {@link Predicate#in(Collection)} for instance
+   */
+  protected Collection<ID> toCollection(Iterable<ID> ids) {
+
+    final Collection<ID> idsList = new ArrayList<>();
+    for (final ID id : ids) {
+      idsList.add(id);
+    }
+    return idsList;
+  }
+
   @Override
   public void delete(ID id) {