Skip to content

Commit 50692ad

Browse files
Merge pull request #175 from NovoNordisk-OpenSource/fix/serviceaccountnamespace
Fix Role & Rolebinding namespace
2 parents c9f0ae8 + ed3e5c7 commit 50692ad

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

helm/oauth2-proxy/Chart.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: oauth2-proxy
2-
version: 6.20.0
2+
version: 6.20.1
33
apiVersion: v2
44
appVersion: 7.5.1
55
home: https://oauth2-proxy.github.io/oauth2-proxy/
@@ -34,8 +34,8 @@ maintainers:
3434
kubeVersion: ">=1.9.0-0"
3535
annotations:
3636
artifacthub.io/changes: |
37-
- kind: added
38-
description: Allow specifying terminationGracePeriodSeconds and lifecycle hooks
37+
- kind: fixed
38+
description: Fixed service account role and rolebinding created in the wrong namespace
3939
links:
4040
- name: Github PR
41-
url: https://github.com/oauth2-proxy/manifests/pull/174
41+
url: https://github.com/oauth2-proxy/manifests/pull/175

helm/oauth2-proxy/templates/serviceaccount.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ kind: Role
2424
apiVersion: rbac.authorization.k8s.io/v1
2525
metadata:
2626
name: {{ $fullName }}-watch-redis
27+
namespace: {{ $namespace }}
2728
labels:
2829
app: {{ $name }}
2930
{{- $labels | nindent 4 }}
@@ -43,6 +44,7 @@ kind: RoleBinding
4344
apiVersion: rbac.authorization.k8s.io/v1
4445
metadata:
4546
name: {{ $saName }}-watch-redis
47+
namespace: {{ $namespace }}
4648
labels:
4749
app: {{ $name }}
4850
{{- $labels | nindent 4 }}

0 commit comments

Comments
 (0)