Skip to content

Commit c39483f

Browse files
authored
Apply suggestions from code review
1 parent ccaa68c commit c39483f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

helm/oauth2-proxy/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: oauth2-proxy
2-
version: 7.10.6
2+
version: 7.11.0
33
apiVersion: v2
44
appVersion: 7.8.1
55
home: https://oauth2-proxy.github.io/oauth2-proxy/
@@ -31,7 +31,7 @@ maintainers:
3131
kubeVersion: ">=1.16.0-0"
3232
annotations:
3333
artifacthub.io/changes: |
34-
- kind: changed
34+
- kind: added
3535
description: Make deploy.enableServiceLinks configurable
3636
links:
3737
- name: Github PR

helm/oauth2-proxy/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ The following table lists the configurable parameters of the oauth2-proxy chart
136136
| `config.google.existingConfig` | existing Kubernetes configmap to use for the service account file. See [Google secret template](https://github.com/oauth2-proxy/manifests/blob/master/helm/oauth2-proxy/templates/google-secret.yaml) for the required values | `nil` |
137137
| `config.google.groups` | restrict logins to members of these Google groups | `[]` |
138138
| `containerPort` | used to customize port on the deployment | `""` |
139-
| `enableServiceLinks` | configure deployment enableServiceLinks | `{}` |
139+
| `enableServiceLinks` | configure deployment enableServiceLinks | `true` |
140140
| `extraArgs` | Extra arguments to give the binary. Either as a map with key:value pairs or as a list type, which allows the same flag to be configured multiple times. (e.g. `["--allowed-role=CLIENT_ID:CLIENT_ROLE_NAME_A", "--allowed-role=CLIENT_ID:CLIENT_ROLE_NAME_B"]`). | `{}` or `[]` |
141141
| `extraContainers` | List of extra containers to be added to the pod | `[]` |
142142
| `extraEnv` | key:value list of extra environment variables to give the binary | `[]` |

0 commit comments

Comments
 (0)