fix: Declare error variable and use assignment for spinner (#40)

mgudemann · web-flow · commit 546f07f3ccd9 · 2024-12-10T08:01:34.000+01:00
Thanks to @mgudemann
diff --git a/git/clone.go b/git/clone.go
@@ -63,9 +63,10 @@ func clone(localpath, branch, cloneurl string, auth ssh.AuthMethod, force bool,
 	}
 
 	var spinner *yacspin.Spinner
+	var err error
 
 	if !noSpinner {
-		spinner, err := yacspin.New(cfg)
+		spinner, err = yacspin.New(cfg)
 		if err != nil {
 			log.Debug().Err(err).Msg("cannot create spinner")
 		}
@@ -97,7 +98,7 @@ func clone(localpath, branch, cloneurl string, auth ssh.AuthMethod, force bool,
 		}
 	}
 
-	_, err := git.PlainClone(localpath, false, &git.CloneOptions{
+	_, err = git.PlainClone(localpath, false, &git.CloneOptions{
 		Auth:          auth,
 		URL:           cloneurl,
 		ReferenceName: plumbing.ReferenceName("refs/heads/" + branch),

Original file line number	Diff line number	Diff line change
`@@ -63,9 +63,10 @@ func clone(localpath, branch, cloneurl string, auth ssh.AuthMethod, force bool,`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`var spinner *yacspin.Spinner`
	`66`	`+ var err error`
`66`	`67`
`67`	`68`	`if !noSpinner {`
`68`		`- spinner, err := yacspin.New(cfg)`
	`69`	`+ spinner, err = yacspin.New(cfg)`
`69`	`70`	`if err != nil {`
`70`	`71`	`log.Debug().Err(err).Msg("cannot create spinner")`
`71`	`72`	`}`
`@@ -97,7 +98,7 @@ func clone(localpath, branch, cloneurl string, auth ssh.AuthMethod, force bool,`
`97`	`98`	`}`
`98`	`99`	`}`
`99`	`100`
`100`		`- _, err := git.PlainClone(localpath, false, &git.CloneOptions{`
	`101`	`+ _, err = git.PlainClone(localpath, false, &git.CloneOptions{`
`101`	`102`	`Auth: auth,`
`102`	`103`	`URL: cloneurl,`
`103`	`104`	`ReferenceName: plumbing.ReferenceName("refs/heads/" + branch),`