Cache iota renderers to improve performance

Author: object-Object

CHANGELOG.md

@@ -27,6 +27,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 - Added (official) support for inserting iota-holding items other than foci into the Focal Frame.
 - A single Focal Frame item can now be used like a bundle to insert/remove items in your inventory.
 - The Focal Frame now gives comparator output and can be broken by pushing it with a piston.
+- Splicing Table iota renderers are now cached to improve performance.
 
 ### Fixed
 

Common/src/main/java/gay/object/hexdebug/api/client/splicing/SplicingTableIotaRenderer.java

@@ -8,15 +8,16 @@
 import net.minecraft.client.gui.GuiGraphics;
 import net.minecraft.client.gui.components.Tooltip;
 import net.minecraft.network.chat.Component;
+import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
 
 public abstract class SplicingTableIotaRenderer {
     @NotNull
     private final IotaType<?> type;
     @NotNull
     private final SplicingTableIotaClientView iota;
-    private final int x;
-    private final int y;
+    private int x;
+    private int y;
 
     public SplicingTableIotaRenderer(
         @NotNull IotaType<?> type,
@@ -44,10 +45,20 @@ public final int getX() {
         return x;
     }
 
+    @ApiStatus.OverrideOnly
+    public void setX(int x) {
+        this.x = x;
+    }
+
     public final int getY() {
         return y;
     }
 
+    @ApiStatus.OverrideOnly
+    public void setY(int y) {
+        this.y = y;
+    }
+
     /** Renders one frame of this iota. */
     public abstract void render(@NotNull GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTick);
 

Common/src/main/kotlin/gay/object/hexdebug/gui/splicing/renderers/List.kt

@@ -28,6 +28,16 @@ class ListRenderer(
         return super.buildTooltip()
             .addAdvancedLine(SplicingTableScreen.tooltipText("length", listTag.size))
     }
+
+    override fun setX(x: Int) {
+        super.setX(x)
+        inner?.x = x
+    }
+
+    override fun setY(y: Int) {
+        super.setY(y)
+        inner?.y = y
+    }
 }
 
 class ListRendererProvider(private val inner: SplicingTableIotaRendererProvider) : SplicingTableIotaRendererProvider {

Common/src/main/kotlin/gay/object/hexdebug/gui/splicing/widgets/BaseIotaButton.kt

@@ -2,12 +2,14 @@ package gay.`object`.hexdebug.gui.splicing.widgets
 
 import at.petrak.hexcasting.api.casting.iota.IotaType
 import at.petrak.hexcasting.common.lib.hex.HexIotaTypes
+import com.google.common.cache.CacheBuilder
 import com.mojang.blaze3d.systems.RenderSystem
 import gay.`object`.hexdebug.HexDebug
 import gay.`object`.hexdebug.api.client.splicing.SplicingTableIotaRenderer
 import gay.`object`.hexdebug.api.client.splicing.SplicingTableIotaRenderers
 import gay.`object`.hexdebug.api.splicing.SplicingTableIotaClientView
 import net.minecraft.client.gui.GuiGraphics
+import net.minecraft.client.gui.components.Tooltip
 import net.minecraft.network.chat.Component
 
 abstract class BaseIotaButton(x: Int, y: Int) : HexagonButton(
@@ -59,14 +61,25 @@ abstract class BaseIotaButton(x: Int, y: Int) : HexagonButton(
 
         active = true
 
-        try {
-            renderer = SplicingTableIotaRenderers.getProvider(iotaType)
-                ?.createRenderer(iotaType, iotaView, x, y)
-
-            tooltip = renderer?.createTooltip()
-        } catch (e: Exception) {
-            HexDebug.LOGGER.error("Caught exception while preparing renderer for ${iotaType.typeName().string}", e)
-            renderer = null
+        val (renderer, tooltip) = rendererCache.get(iotaView) {
+            try {
+                val renderer = SplicingTableIotaRenderers.getProvider(iotaType)
+                    ?.createRenderer(iotaType, iotaView, x, y)
+                renderer to renderer?.createTooltip()
+            } catch (e: Exception) {
+                HexDebug.LOGGER.error("Caught exception while preparing renderer for ${iotaType.typeName().string}", e)
+                null to null
+            }
         }
+        renderer?.x = x
+        renderer?.y = y
+        this.renderer = renderer
+        this.tooltip = tooltip
+    }
+
+    companion object {
+        private val rendererCache = CacheBuilder.newBuilder()
+            .maximumSize(HexIotaTypes.MAX_SERIALIZATION_TOTAL * 2L)
+            .build<SplicingTableIotaClientView, Pair<SplicingTableIotaRenderer?, Tooltip?>>()
     }
 }