Clean up pause/restart logic

Author: object-Object

Common/src/main/kotlin/gay/object/hexdebug/adapter/DebugAdapter.kt

@@ -134,7 +134,7 @@ class DebugAdapter(val player: ServerPlayer) : IDebugProtocolServer {
         val result = debugger.startExecuting(env, iotas)
             ?: throw IllegalDebugSessionException("Debug session is already executing something")
         lastDebugger = debugger
-        handleDebuggerStep(debugger.threadId, result)
+        handleDebuggerStep(debugger.threadId, result, wasPaused = false)
     }
 
     fun disconnectClient() {
@@ -207,7 +207,11 @@ class DebugAdapter(val player: ServerPlayer) : IDebugProtocolServer {
             ?: ResponseError(ResponseErrorCode.InternalError, e.toString(), e.stackTraceToString())
     }
 
-    private fun handleDebuggerStep(threadId: Int, result: DebugStepResult): ExecutionClientView? {
+    private fun handleDebuggerStep(
+        threadId: Int,
+        result: DebugStepResult,
+        wasPaused: Boolean = true,
+    ): ExecutionClientView? {
         val view = result.clientInfo?.also {
             MsgEvaluatorClientInfoS2C(threadId, it).sendToPlayer(player)
         }
@@ -234,7 +238,7 @@ class DebugAdapter(val player: ServerPlayer) : IDebugProtocolServer {
             debugger(threadId)?.getNextIotaToEvaluate()?.also { (iota, index) ->
                 printDebuggerStatus(iota, index)
             }
-        } else {
+        } else if (wasPaused) {
             // running
             remoteProxy.continued(ContinuedEventArguments().also {
                 it.threadId = threadId

Common/src/main/kotlin/gay/object/hexdebug/debugger/HexDebugger.kt

@@ -411,6 +411,11 @@ class HexDebugger(
         return result
     }
 
+    fun pause() {
+        lastStepType = RequestStepType.IN
+        debugEnv.pause()
+    }
+
     fun executeUntilStopped(stepType: RequestStepType? = null): DebugStepResult {
         val vm = getVM() ?: return DebugStepResult(null)
 

Core/src/main/java/gay/object/hexdebug/core/api/debugging/DebugEnvironment.java

@@ -33,9 +33,8 @@ protected DebugEnvironment(@NotNull ServerPlayer caster) {
 
     /**
      * Attempts to pause the debuggee. This is called by the debugger when requested by the user.
-     * @return whether the debuggee was successfully paused
      */
-    public abstract boolean pause();
+    public abstract void pause();
 
     /**
      * Attempts to resume execution of the debuggee. This is called by the debugger after the
@@ -54,9 +53,8 @@ public abstract boolean resume(
      * <br>
      * The previous debug thread is removed before this method is called, so the implementation may
      * use {@link HexDebugCoreAPI#createDebugThread} and {@link HexDebugCoreAPI#startExecuting}.
-     * @return whether the debuggee was successfully restarted
      */
-    public abstract boolean restart(int threadId);
+    public abstract void restart(int threadId);
 
     /**
      * For in-world debugees, returns whether the caster is close enough to the debuggee to allow

Core/src/main/java/gay/object/hexdebug/core/api/debugging/SimplePlayerBasedDebugEnv.java

@@ -31,9 +31,7 @@ public SimplePlayerBasedDebugEnv(
     }
 
     @Override
-    public boolean pause() {
-        return false;
-    }
+    public void pause() {}
 
     @Override
     public boolean resume(
@@ -45,13 +43,10 @@ public boolean resume(
     }
 
     @Override
-    public boolean restart(int threadId) {
+    public void restart(int threadId) {
         try {
             start(threadId);
-            return true;
-        } catch (DebugException ignored) {
-            return false;
-        }
+        } catch (DebugException ignored) {}
     }
 
     @Override