Move exceptions to dedicated file

Author: object-Object

bot/src/ghutils/cogs/app_commands/github.py

@@ -20,7 +20,8 @@
 
 from ghutils.common.__version__ import VERSION
 from ghutils.core.cog import GHUtilsCog, SubGroup
-from ghutils.core.types import InvalidInputError, LoginState, NotLoggedInError
+from ghutils.core.exceptions import InvalidInputError, NotLoggedInError
+from ghutils.core.types import LoginState
 from ghutils.db.models import (
     UserGitHubTokens,
     UserLogin,

bot/src/ghutils/core/exceptions.py

@@ -0,0 +1,28 @@
+from typing import Any
+
+from discord.app_commands import AppCommandError
+
+
+# TODO: add Literal[LoginState.LOGGED_OUT, LoginState.EXPIRED] parameter
+class NotLoggedInError(AppCommandError):
+    """An exception raised when the command user is not logged in to GitHub.
+
+    Commands that require the user of the command to log in with GitHub can throw this
+    if the user is not logged in to reply with a standard error message.
+    """
+
+
+class SilentError(AppCommandError):
+    """Base class for exceptions that should be silently caught and ignored."""
+
+
+class InvalidInputError(AppCommandError):
+    """An exception raised within command handlers when an input value is invalid.
+
+    Displays a similar error message as `TransformerError`.
+    """
+
+    def __init__(self, value: Any, message: str):
+        self.value = value
+        self.message = message
+        super().__init__(f"{message} (value: {value})")

bot/src/ghutils/core/tree.py

@@ -10,7 +10,7 @@
     TransformerError,
 )
 
-from .types import InvalidInputError, NotLoggedInError, SilentError
+from .exceptions import InvalidInputError, NotLoggedInError, SilentError
 
 
 class GHUtilsCommandTree(CommandTree):

bot/src/ghutils/core/types.py

@@ -1,35 +1,7 @@
 from enum import Enum, auto
-from typing import Any
-
-from discord.app_commands import AppCommandError
 
 
 class LoginState(Enum):
     LOGGED_IN = auto()
     LOGGED_OUT = auto()
     EXPIRED = auto()
-
-
-# TODO: add Literal[LoginState.LOGGED_OUT, LoginState.EXPIRED] parameter
-class NotLoggedInError(AppCommandError):
-    """An exception raised when the command user is not logged in to GitHub.
-
-    Commands that require the user of the command to log in with GitHub can throw this
-    if the user is not logged in to reply with a standard error message.
-    """
-
-
-class SilentError(AppCommandError):
-    """Base class for exceptions that should be silently caught and ignored."""
-
-
-class InvalidInputError(AppCommandError):
-    """An exception raised within command handlers when an input value is invalid.
-
-    Displays a similar error message as `TransformerError`.
-    """
-
-    def __init__(self, value: Any, message: str):
-        self.value = value
-        self.message = message
-        super().__init__(f"{message} (value: {value})")