Verify external type to be known ones

Author: greenrobot

internal/generator/binding/field.go

@@ -125,7 +125,12 @@ func (field *Field) ProcessAnnotations(a map[string]*Annotation) error {
 		field.ModelProperty.ExternalName = a["external-name"].Value
 	}
 	if a["external-type"] != nil {
-		field.ModelProperty.ExternalType = model.ExternalTypeValues[a["external-type"].Value]
+		externalTypeValue := a["external-type"].Value
+		externalType, exists := model.ExternalTypeValues[externalTypeValue]
+		if !exists {
+			return fmt.Errorf("invalid external-type '%s' for property %s - must be one of the supported external types", externalTypeValue, field.Name)
+		}
+		field.ModelProperty.ExternalType = externalType
 	}
 
 	if a["index"] != nil {

internal/generator/binding/object.go

@@ -140,7 +140,12 @@ func (object *Object) AddRelation(details map[string]*Annotation) (*model.Standa
 	}
 
 	if details["external-type"] != nil {
-		relation.ExternalType = model.ExternalTypeValues[details["external-type"].Value]
+		externalTypeValue := details["external-type"].Value
+		externalType, exists := model.ExternalTypeValues[externalTypeValue]
+		if !exists {
+			return nil, fmt.Errorf("invalid external-type '%s' for relation %s - must be one of the supported external types", externalTypeValue, relation.Name)
+		}
+		relation.ExternalType = externalType
 	}
 
 	// NOTE: we don't need an actual entity pointer, it's resolved during stored model merging.

test/comparison/test-all.go

@@ -255,8 +255,16 @@ func generateAllFiles(t *testing.T, overwriteExpected bool, conf testSpec, srcDi
 			if err == nil {
 				assert.Failf(t, "Unexpected PASS on a negative test %s", sourceFile)
 			} else {
-				var errPlatformIndependent = strings.Replace(err.Error(), "\\", "/", -1)
-				assert.Eq(t, getExpectedError(t, sourceFile).Error(), errPlatformIndependent)
+				var unifiedError = strings.Replace(err.Error(), "\\", "/", -1) // "Unify" Windows paths
+				expectedError := getExpectedError(t, sourceFile).Error()
+				if strings.HasPrefix(unifiedError, "error generating model from schema ") {
+					// Compare only the last part of unifiedError as it contains the full path to the schema file
+					unifiedError = unifiedError[len(unifiedError)-len(expectedError):]
+					if unifiedError != expectedError {
+						t.Logf("Full error: %s", err) // Initial error, which may contain additional information
+					}
+				}
+				assert.Eq(t, expectedError, unifiedError)
 				continue
 			}
 		} else {

test/comparison/testdata/fbs/external-type-invalid/InvalidExternalType.fail.fbs

@@ -0,0 +1,8 @@
+// ERROR = object 0 test.EntityWithInvalidExternalType: field 0 data: invalid external-type 'InvalidTypeName' for property data - must be one of the supported external types
+namespace test;
+
+table EntityWithInvalidExternalType {
+    id: ulong;
+    /// objectbox: external-type=InvalidTypeName
+    data: string;
+}

test/comparison/testdata/fbs/external-type-invalid/InvalidRelationExternalType.fail.fbs

@@ -0,0 +1,12 @@
+// ERROR = invalid external-type 'NonExistentType' for relation children - must be one of the supported external types
+namespace test;
+
+table Child {
+    id: ulong;
+    text: string;
+}
+
+/// objectbox:relation(name=children, to=Child, external-type=NonExistentType)
+table Parent {
+    id: ulong;
+}