Server options: drop re-mapping to SHARED_SECRET workaround

Author: greenrobot-team

objectbox-java/src/main/java/io/objectbox/sync/SyncCredentials.java

@@ -62,7 +62,6 @@ public static SyncCredentials none() {
     public enum CredentialsType {
 
         NONE(io.objectbox.sync.CredentialsType.None),
-        SHARED_SECRET(io.objectbox.sync.CredentialsType.SharedSecret),
         GOOGLE(io.objectbox.sync.CredentialsType.GoogleAuth),
         SHARED_SECRET_SIPPED(io.objectbox.sync.CredentialsType.SharedSecretSipped),
         OBX_ADMIN_USER(io.objectbox.sync.CredentialsType.ObxAdminUser),

objectbox-java/src/main/java/io/objectbox/sync/server/SyncServerBuilder.java

@@ -204,13 +204,7 @@ private int buildCredentials(FlatBufferBuilder fbb, SyncCredentialsToken tokenCr
         }
 
         Credentials.startCredentials(fbb);
-        // TODO Will this still be necessary?
-        // The core API used by nativeSetAuthenticator only supports the NONE and SHARED_SECRET types
-        // (however, protocol v3 versions do also add SHARED_SECRET_SIPPED if SHARED_SECRET is given).
-        final SyncCredentials.CredentialsType type = tokenCredentials.getType() == SyncCredentials.CredentialsType.SHARED_SECRET_SIPPED
-                ? SyncCredentials.CredentialsType.SHARED_SECRET
-                : tokenCredentials.getType();
-        Credentials.addType(fbb, type.id);
+        Credentials.addType(fbb, tokenCredentials.getTypeId());
         if (tokenBytesOffset > 0) {
             Credentials.addBytes(fbb, tokenBytesOffset);
         }