ToMany: suppress casting warnings.

Author: greenrobot-team

objectbox-java/src/main/java/io/objectbox/relation/ToMany.java

@@ -89,6 +89,7 @@ public class ToMany<TARGET> implements List<TARGET>, Serializable {
     transient private boolean removeFromTargetBox;
     transient private Comparator<TARGET> comparator;
 
+    @SuppressWarnings("unchecked") // RelationInfo cast: ? is at least Object.
     public ToMany(Object sourceEntity, RelationInfo<?, TARGET> relationInfo) {
         //noinspection ConstantConditions Annotation does not enforce non-null.
         if (sourceEntity == null) {
@@ -378,6 +379,7 @@ public synchronized TARGET remove(int location) {
         return removed;
     }
 
+    @SuppressWarnings("unchecked") // Cast to TARGET: If removed, must be of type TARGET.
     @Override
     public synchronized boolean remove(Object object) {
         ensureEntitiesWithTrackingLists();
@@ -473,6 +475,7 @@ public Object[] toArray() {
     @Nonnull
     public <T> T[] toArray(T[] array) {
         ensureEntities();
+        //noinspection SuspiciousToArrayCall Caller must pass T that is supertype of TARGET.
         return entities.toArray(array);
     }
 
@@ -571,9 +574,10 @@ public void applyChangesToDb() {
      */
     @Beta
     public boolean hasA(QueryFilter<TARGET> filter) {
-        Object[] objects = toArray();
-        for (Object target : objects) {
-            if (filter.keep((TARGET) target)) {
+        @SuppressWarnings("unchecked") // Can't toArray(new TARGET[0]).
+        TARGET[] objects = (TARGET[]) toArray();
+        for (TARGET target : objects) {
+            if (filter.keep(target)) {
                 return true;
             }
         }
@@ -588,12 +592,13 @@ public boolean hasA(QueryFilter<TARGET> filter) {
      */
     @Beta
     public boolean hasAll(QueryFilter<TARGET> filter) {
-        Object[] objects = toArray();
+        @SuppressWarnings("unchecked") // Can't toArray(new TARGET[0]).
+        TARGET[] objects = (TARGET[]) toArray();
         if (objects.length == 0) {
             return false;
         }
-        for (Object target : objects) {
-            if (!filter.keep((TARGET) target)) {
+        for (TARGET target : objects) {
+            if (!filter.keep(target)) {
                 return false;
             }
         }
@@ -604,12 +609,12 @@ public boolean hasAll(QueryFilter<TARGET> filter) {
     @Beta
     public TARGET getById(long id) {
         ensureEntities();
-        Object[] objects = entities.toArray();
+        @SuppressWarnings("unchecked") // Can't toArray(new TARGET[0]).
+        TARGET[] objects = (TARGET[]) entities.toArray();
         IdGetter<TARGET> idGetter = relationInfo.targetInfo.getIdGetter();
-        for (Object target : objects) {
-            TARGET candidate = (TARGET) target;
-            if (idGetter.getId(candidate) == id) {
-                return candidate;
+        for (TARGET target : objects) {
+            if (idGetter.getId(target) == id) {
+                return target;
             }
         }
         return null;
@@ -619,12 +624,12 @@ public TARGET getById(long id) {
     @Beta
     public int indexOfId(long id) {
         ensureEntities();
-        Object[] objects = entities.toArray();
+        @SuppressWarnings("unchecked") // Can't toArray(new TARGET[0]).
+        TARGET[] objects = (TARGET[]) entities.toArray();
         IdGetter<TARGET> idGetter = relationInfo.targetInfo.getIdGetter();
         int index = 0;
-        for (Object target : objects) {
-            TARGET candidate = (TARGET) target;
-            if (idGetter.getId(candidate) == id) {
+        for (TARGET target : objects) {
+            if (idGetter.getId(target) == id) {
                 return index;
             }
             index++;
@@ -780,6 +785,7 @@ private boolean prepareToOneBacklinkEntitiesForDb(long entityId, IdGetter<TARGET
      * For internal use only; do not use in your app.
      * Convention: {@link #internalCheckApplyToDbRequired()} must be called before this call as it prepares .
      */
+    @SuppressWarnings("unchecked") // Can't toArray(new TARGET[0]).
     @Internal
     public void internalApplyToDb(Cursor<?> sourceCursor, Cursor<TARGET> targetCursor) {
         TARGET[] toRemoveFromDb;