Deprecated APIs: remove BoxStore.sizeOnDisk

This was deprecated in release 4.0.0

Author: greenrobot-team

CHANGELOG.md

@@ -13,6 +13,7 @@ For more insights into what changed in the ObjectBox C++ core, [check the Object
 - To help diagnose, print stacks of all threads in the internal thread pool if shutting it down takes too long when
   closing `BoxStore`.
 - Remove deprecated `Box.removeByKeys`, use `Box.removeByIds` instead.
+- Remove deprecated `BoxStore.sizeOnDisk`, use `getDbSize` or `getDbSizeOnDisk` instead which properly handle in-memory databases.
 - Remove deprecated `SyncServerBuilder` `peer` configuration options, use the `clusterPeer` options instead.
 - Remove deprecated `io.objectbox.DebugFlags`, use `io.objectbox.config.DebugFlags` instead.
 - Remove deprecated `ValidateOnOpenMode` constants, use `ValidateOnOpenModePages` instead.

objectbox-java/src/main/java/io/objectbox/BoxStore.java

@@ -513,17 +513,6 @@ public static long sysProcStatusKb(String key) {
         return nativeSysProcStatusKb(key);
     }
 
-    /**
-     * The size in bytes occupied by the data file on disk.
-     *
-     * @return 0 if the size could not be determined (does not throw unless this store was already closed)
-     * @deprecated Use {@link #getDbSize()} or {@link #getDbSizeOnDisk()} instead which properly handle in-memory databases.
-     */
-    @Deprecated
-    public long sizeOnDisk() {
-        return getDbSize();
-    }
-
     /**
      * Get the size of this store. For a disk-based store type, this corresponds to the size on disk, and for the
      * in-memory store type, this is roughly the used memory bytes occupied by the data.

tests/objectbox-java-test/src/test/java/io/objectbox/BoxStoreTest.java

@@ -113,7 +113,6 @@ public void testClose() {
         store.setSyncClient(null);
 
         // Methods using the native store should throw.
-        assertThrowsStoreIsClosed(store::sizeOnDisk);
         assertThrowsStoreIsClosed(store::getDbSize);
         assertThrowsStoreIsClosed(store::getDbSizeOnDisk);
         assertThrowsStoreIsClosed(store::beginTx);
@@ -322,10 +321,6 @@ private Callable<String> createTestCallable(final int[] countHolder) {
     @Test
     public void testSizeOnDisk() {
         // Note: initial database does have a non-zero (file) size.
-        @SuppressWarnings("deprecation")
-        long legacySizeOnDisk = store.sizeOnDisk();
-        assertTrue(legacySizeOnDisk > 0);
-
         assertTrue(store.getDbSize() > 0);
 
         long sizeOnDisk = store.getDbSizeOnDisk();