TransactionTest: use noReaderThreadLocals to fix unbounded threads tests

Author: greenrobot

tests/objectbox-java-test/src/test/java/io/objectbox/TransactionTest.java

@@ -19,14 +19,14 @@
 import io.objectbox.exception.DbException;
 import io.objectbox.exception.DbExceptionListener;
 import io.objectbox.exception.DbMaxReadersExceededException;
-import io.objectbox.internal.ObjectBoxThreadPool;
 import org.junit.Ignore;
 import org.junit.Test;
 
 import java.util.ArrayList;
 import java.util.concurrent.Callable;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
@@ -447,6 +447,16 @@ public void testCallInTxAsync_Error() throws InterruptedException {
         assertNotNull(result);
     }
 
+    @Test
+    public void transaction_unboundedThreadPool() throws Exception {
+        runThreadPoolReaderTest(
+                () -> {
+                    Transaction tx = store.beginReadTx();
+                    tx.close();
+                }
+        );
+    }
+
     @Test
     public void runInReadTx_unboundedThreadPool() throws Exception {
         runThreadPoolReaderTest(
@@ -483,10 +493,11 @@ private void runThreadPoolReaderTest(Runnable runnable) throws Exception {
         store = createBoxStoreBuilder(null)
                 .maxReaders(100)
                 .debugFlags(0)
+                .noReaderThreadLocals()  // This is the essential flag to make this test work
                 .build();
 
         // Unbounded thread pool so number of threads run exceeds max readers.
-        ExecutorService pool = new ObjectBoxThreadPool(store);
+        ExecutorService pool = Executors.newCachedThreadPool();
 
         ArrayList<Future<Integer>> txTasks = new ArrayList<>(10000);
         final Object lock = new Object();
@@ -503,7 +514,7 @@ private void runThreadPoolReaderTest(Runnable runnable) throws Exception {
 
         //Iterate through all the txTasks and make sure all transactions succeeded.
         for (Future<Integer> txTask : txTasks) {
-            txTask.get(1, TimeUnit.SECONDS);
+            txTask.get(1, TimeUnit.MINUTES);  // 1s would be enough for normally, but use 1 min to allow debug sessions
         }
     }
 }