BoxStore: remove logs to debug open file checker thread and finalization

Author: greenrobot-team

objectbox-java/src/main/java/io/objectbox/BoxStore.java

@@ -358,11 +358,10 @@ static String getCanonicalPath(File directory) {
         }
     }
 
-    void verifyNotAlreadyOpen(String canonicalPath) {
+    static void verifyNotAlreadyOpen(String canonicalPath) {
         synchronized (openFiles) {
-            boolean fileOpen = isFileOpen(canonicalPath); // for retries
+            isFileOpen(canonicalPath); // for retries
             if (!openFiles.add(canonicalPath)) {
-                System.out.println("verifyNotAlreadyOpen failed for " + this + " (fileOpen=" + fileOpen + ")");
                 throw new DbException("Another BoxStore is still open for this directory: " + canonicalPath +
                         ". Hint: for most apps it's recommended to keep a BoxStore for the app's life time.");
             }
@@ -378,8 +377,7 @@ static boolean isFileOpen(final String canonicalPath) {
         if (checkerThread == null || !checkerThread.isAlive()) {
             // Use a thread to avoid finalizers that block us
             checkerThread = new Thread(() -> {
-                boolean fileOpen = isFileOpenSync(canonicalPath, true);
-                System.out.println("checkerThread retries completed (fileOpen=" + fileOpen + ")");
+                isFileOpenSync(canonicalPath, true);
                 BoxStore.openFilesCheckerThread = null; // Clean ref to itself
             });
             checkerThread.setDaemon(true);
@@ -405,7 +403,6 @@ static boolean isFileOpenSync(String canonicalPath, boolean runFinalization) {
             int tries = 0;
             while (tries < 5 && openFiles.contains(canonicalPath)) {
                 tries++;
-                System.out.println("isFileOpenSync calling System.gc() and System.runFinalization()");
                 System.gc();
                 if (runFinalization && tries > 1) System.runFinalization();
                 System.gc();
@@ -532,7 +529,6 @@ public long getDbSizeOnDisk() {
     @SuppressWarnings("deprecation") // finalize()
     @Override
     protected void finalize() throws Throwable {
-        System.out.println("finalize() called for " + this + " by " + Thread.currentThread());
         close();
         super.finalize();
     }
@@ -658,7 +654,6 @@ public boolean isReadOnly() {
      * are properly finished.
      */
     public void close() {
-        System.out.println("close() called for " + this + " (handle=" + handle + ")");
         boolean oldClosedState;
         synchronized (this) {
             oldClosedState = closed;
@@ -721,7 +716,6 @@ public void close() {
                 openFiles.notifyAll();
             }
         }
-        System.out.println("close() finished for " + this);
     }
 
     /** dump thread stacks if pool does not terminate promptly. */